From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 1 Nov 2010 14:20:35 +0100 Subject: [U-Boot] [PATCH 4/4] UBI/UBIFS: Prevent UBI partition change while UBIFS is mounted In-Reply-To: <20101029210612.BB8D6152451@gemini.denx.de> References: <1288267776-1148-1-git-send-email-sr@denx.de> <20101029210612.BB8D6152451@gemini.denx.de> Message-ID: <201011011420.35851.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On Friday 29 October 2010 23:06:12 Wolfgang Denk wrote: > > Only allow (re-)assignment to an UBI partition/device when UBIFS is > > currently not mounted. Otherwise the following UBIFS commands will > > crash. > > > > Signed-off-by: Stefan Roese > > --- > > > > common/cmd_ubi.c | 13 +++++++++++++ > > common/cmd_ubifs.c | 5 +++++ > > 2 files changed, 18 insertions(+), 0 deletions(-) > > I'm a bit biased here - from standard Unix command usage it seems > natural that you have to manually umount first, but then we have very > smple device handling in U-Boot, with always only one device in > access. Would it not make sense to auto-unmount in case the user > switches the device? I can implement it this way if preferred. I'll prepare a new for this later. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de