public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARMV7: Overo: Automatically set clock rate to maximum if mpurate env variable is "auto"
Date: Sun, 07 Nov 2010 22:43:46 +0100	[thread overview]
Message-ID: <20101107214346.1DF2E220@gemini.denx.de> (raw)
In-Reply-To: <1289012370.18546.66.camel@quadra>

Dear Steve Sakoman,

In message <1289012370.18546.66.camel@quadra> you wrote:
> The maximum clock rate for the OMAP3 processors on Overo depends on the
> processor type and revision.  This patch sets the clock rate to the
> spec sheet maximum if the mpurate environment variable is set to
> "auto".  Otherwise it passes the mpurate variable unchanged on the
> kernel command line.

I don't think this is a good idea.

This logic does not belong into U-Boot; if anywhere, it belongs into
the Linux kernel code.  If I want to pass any specific value to the
Linux kernel I want that U-Boot does not get in my way. And if I
decide to set the mpurate to "auto" I want that U-Boot keeps this
setting and does not change it silently behind my back into something
else.

Both looks conceptually broken to me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It became apparent that one reason why the Ice Giants were  known  as
the  Ice  Giants  was  because they were, well, giants. The other was
that they were made of ice.              -Terry Pratchett, _Sourcery_

  parent reply	other threads:[~2010-11-07 21:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06  2:59 [U-Boot] [PATCH] ARMV7: Overo: Automatically set clock rate to maximum if mpurate env variable is "auto" Steve Sakoman
2010-11-06  4:44 ` Nishanth Menon
2010-11-07 21:43 ` Wolfgang Denk [this message]
2010-11-08  8:46   ` Premi, Sanjeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101107214346.1DF2E220@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox