From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sun, 07 Nov 2010 22:43:46 +0100
Subject: [U-Boot] [PATCH] ARMV7: Overo: Automatically set clock rate to
	maximum if mpurate env variable is "auto"
In-Reply-To: <1289012370.18546.66.camel@quadra>
References: <1289012370.18546.66.camel@quadra>
Message-ID: <20101107214346.1DF2E220@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Steve Sakoman,

In message <1289012370.18546.66.camel@quadra> you wrote:
> The maximum clock rate for the OMAP3 processors on Overo depends on the
> processor type and revision.  This patch sets the clock rate to the
> spec sheet maximum if the mpurate environment variable is set to
> "auto".  Otherwise it passes the mpurate variable unchanged on the
> kernel command line.

I don't think this is a good idea.

This logic does not belong into U-Boot; if anywhere, it belongs into
the Linux kernel code.  If I want to pass any specific value to the
Linux kernel I want that U-Boot does not get in my way. And if I
decide to set the mpurate to "auto" I want that U-Boot keeps this
setting and does not change it silently behind my back into something
else.

Both looks conceptually broken to me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It became apparent that one reason why the Ice Giants were  known  as
the  Ice  Giants  was  because they were, well, giants. The other was
that they were made of ice.              -Terry Pratchett, _Sourcery_