public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] kirkwood: CONFIG_SYS_INIT_SP_ADDR wrong?
Date: Wed, 10 Nov 2010 21:11:21 +0100	[thread overview]
Message-ID: <20101110201121.7C54F1522C0@gemini.denx.de> (raw)
In-Reply-To: <4CDABCF8.901@denx.de>

Dear Heiko Schocher,

In message <4CDABCF8.901@denx.de> you wrote:
> 
> Then we should add this alignment into the generation of
> GENERATED_GBL_DATA_SIZE.

No.  GENERATED_GBL_DATA_SIZE is just a size.  As you don't really know
the alignment of the base address that GENERATED_GBL_DATA_SIZE is
added to or substracted from, you cannot add the alignment
requirements here.

This must be done where they are neede d- whichis also much better to
make the code readable / understandable.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He'd been wrong, there _was_ a light at the end of the tunnel, and it
was a flamethrower.                         - Terry Pratchett, _Mort_

      parent reply	other threads:[~2010-11-10 20:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-10 13:57 [U-Boot] kirkwood: CONFIG_SYS_INIT_SP_ADDR wrong? Daniel Hobi
2010-11-10 14:15 ` Heiko Schocher
2010-11-10 14:37   ` Daniel Hobi
2010-11-10 15:02     ` Heiko Schocher
2010-11-10 15:13       ` Daniel Hobi
2010-11-10 15:40         ` Heiko Schocher
2010-11-10 15:46           ` Daniel Hobi
2010-11-10 16:29             ` Albert ARIBAUD
2010-11-10 16:46             ` Heiko Schocher
2010-11-10 17:53               ` Daniel Hobi
2010-11-10 20:13               ` Wolfgang Denk
2010-11-10 20:11           ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101110201121.7C54F1522C0@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox