public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f
Date: Fri, 12 Nov 2010 09:50:13 +0100	[thread overview]
Message-ID: <20101112085013.62415193@gemini.denx.de> (raw)
In-Reply-To: <4CDCE769.8080209@emk-elektronik.de>

Dear Reinhard Meyer,

In message <4CDCE769.8080209@emk-elektronik.de> you wrote:
>
> Is bootflag ever used? If not, why not change the parameter to
> give the gd address to board_init_f?

No, bootflag is never used and could / should be removed.

Passing gd as parameter makes no sense, thoug, as it's global data and
we reserve a register to store it's address, so it can always be used
with minimal overhead.

> One further thought, why not init the reserved register in assembly and
> remove the gd relevant code in C? But that bears some risk if the register
> is changed and the assembly is forgotten to adapt..

We try to do as much as pssible in C, and only what really cannot be
avoided in assembly.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The last thing one knows in constructing a work is what to put first.
- Blaise Pascal

  parent reply	other threads:[~2010-11-12  8:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12  6:53 [U-Boot] [PATCH] arm: add 8-byte alignment for ABI compliance before board_init_f Heiko Schocher
2010-11-12  7:06 ` Reinhard Meyer
2010-11-12  7:19   ` Heiko Schocher
2010-11-12  8:04     ` Albert ARIBAUD
2010-11-12  8:50     ` Graeme Russ
2010-11-12  8:50   ` Wolfgang Denk [this message]
2010-11-12  9:47     ` Graeme Russ
2010-11-12  9:56       ` Wolfgang Denk
2010-11-12  7:53 ` Albert ARIBAUD
2010-11-12  8:05   ` Heiko Schocher
2010-12-08 22:50 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101112085013.62415193@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox