From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH NET 2/2] Net: clarify board/cpu_eth_init calls
Date: Mon, 15 Nov 2010 00:01:41 +0100 [thread overview]
Message-ID: <20101114230141.442D3134FEF@gemini.denx.de> (raw)
In-Reply-To: <1283321104-953-2-git-send-email-biggerbadderben@gmail.com>
Dear Ben Warren,
In message <1283321104-953-2-git-send-email-biggerbadderben@gmail.com> you wrote:
> This has always been confusing, and the idea of these functions returning the
> number of interfaces initialized was half-baked and ultimately pointless.
> Instead, act more like regular functions and return < 0 on failure, >= 0 on
> success.
>
> This change shouldn't break anything.
>
> Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
> ---
> net/eth.c | 16 ++++++++++++----
> 1 files changed, 12 insertions(+), 4 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He is truly wise who gains wisdom from another's mishap.
next prev parent reply other threads:[~2010-11-14 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 6:05 [U-Boot] [PATCH NET 1/2] Net: Remove redundant CONFIG_NET_MULTI directives Ben Warren
2010-09-01 6:05 ` [U-Boot] [PATCH NET 2/2] Net: clarify board/cpu_eth_init calls Ben Warren
2010-09-01 17:04 ` Mike Frysinger
2010-09-01 19:13 ` Ben Warren
2010-11-14 23:01 ` Wolfgang Denk [this message]
2010-09-13 4:07 ` [U-Boot] [PATCH NET 1/2] Net: Remove redundant CONFIG_NET_MULTI directives Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101114230141.442D3134FEF@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox