From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps full duplex in SGMII mode"
Date: Wed, 17 Nov 2010 05:41:04 -0500 [thread overview]
Message-ID: <201011170541.05910.vapier@gentoo.org> (raw)
In-Reply-To: <1289986984-2314-1-git-send-email-b26998@freescale.com>
On Wednesday, November 17, 2010 04:43:04 Zhao Chenhui wrote:
> On P2020DS and MPC8572DS, the link to SGMII card which use Vitesse
> VSC8234 PHY can't come up. Current TBI PHY settings(TBICR_SETTINGS)
> for SGMII mode cause link problems.
>
> Revert commit 46e91674fb4b6d06c6a4984c0b5ac7d9a16923f4, and fix it.
"revert and fix" is not a "revert". the summary you used is reserved for pure
reverts of commits which this is not that. so fix your summary or split the
changes into two commits.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101117/5966a7a7/attachment.pgp
next prev parent reply other threads:[~2010-11-17 10:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 9:43 [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps full duplex in SGMII mode" Zhao Chenhui
2010-11-17 10:41 ` Mike Frysinger [this message]
2010-11-17 13:14 ` Wolfgang Denk
2010-11-17 15:49 ` Peter Tyser
2010-11-18 4:13 ` Li Yang-R58472
2010-11-18 5:01 ` Peter Tyser
2010-11-18 6:50 ` [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps fullduplex " Li Yang-R58472
2010-11-18 15:34 ` Peter Tyser
2010-11-19 5:53 ` Li Yang
2010-11-20 0:01 ` Peter Tyser
2010-12-02 4:52 ` [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps full duplex " Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011170541.05910.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox