[U-Boot] [PATCH v3] Seagate FreeAgent DockStar support

[Eric Cooper <ecc@cmu.edu>]

On Sun, Nov 21, 2010 at 09:37:18PM -0800, Prafulla Wadaskar wrote:
> > diff --git a/board/Seagate/dockstar/kwbimage.cfg
> > b/board/Seagate/dockstar/kwbimage.cfg
> [...]
> Are the contents for this file exactly same as
> sheevaplug/kwbimage.cfg?  If yes then you can reuse that file and
> avoid adding this file here by using configuration in board config
> file.

No, they're different (DockStar has 128M of RAM vs. SheevaPlug's 256M.)

> > diff --git a/boards.cfg b/boards.cfg
> > index 08e531e..50e9d1b 100644
> > --- a/boards.cfg
> > +++ b/boards.cfg
> > @@ -376,6 +376,7 @@ guruplug	arm	arm926ejs	-		Marvell
> > 	kirkwood
> >  mv88f6281gtw_ge	arm	arm926ejs	-		Marvell		kirkwood
> >  openrd_base	arm	arm926ejs	-		Marvell		kirkwood
> >  sheevaplug	arm	arm926ejs	-		Marvell		kirkwood
> > +dockstar	arm	arm926ejs	-		Seagate		Kirkwood
> 
> Please check if you have missed to maintain this in order

I couldn't figure out the intended sort order of the current file.
The comment at the top (about using a sort command) doesn't seem to
match the contents at all, and there are already several arm926ejs and
kirkwood boards in various places.

I'm happy to move this, but please specify exactly where :-)

> > +#define CONFIG_ENV_SIZE			0x20000	/* 128k */
> > +#define CONFIG_ENV_ADDR			0xA0000
> > +#define CONFIG_ENV_OFFSET		0xA0000	/* env starts here */
> 
> u-boot.bin is not more than 0x60000, its better to use env offset at
> 0x60000 to pack u-boot+env in first 512kb

The factory partitioning uses 1M for u-boot, so I wasn't paying
attention to saving space.  But I'll move it down as you suggest.

Thanks for the feedback.

-- 
Eric Cooper             e c c @ c m u . e d u