From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 23 Nov 2010 20:28:17 +0100
Subject: [U-Boot] [PATCH] Fix NAND booting make target
In-Reply-To: <20101123125114.0af65d73@udp111988uds.am.freescale.net>
References: <1290519140-6528-1-git-send-email-sr@denx.de>
	<20101123124504.47667f5b@udp111988uds.am.freescale.net>
	<20101123125114.0af65d73@udp111988uds.am.freescale.net>
Message-ID: <201011232028.17618.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday 23 November 2010 19:51:14 Scott Wood wrote:
> > > Yes, current git head fails to build an many 4xx boards. My patch is on
> > > top of Wolfgangs patchset "[PATCH 0/7] Address partial linking issues"
> > > from 2010-11-21 which fixes most of the 4xx problems. But without this
> > > patch, no object was built in the nand_spl directory at all. Not sure
> > > if I overlooked something though.
> > 
> > Perhaps it has to do with the 4xx boards having NAND_U_BOOT directly in
> > boards.cfg, while the Freescale boards typically have NAND there, and
> > define NAND_U_BOOT in the makefile.
> > 
> > I think the proper fix is to figure out how those quotes are being
> > injected into the make variable.
> 
> Try removing the "=y" in boards.cfg.  tools/scripts/define2mk.sed will
> add quotes to things that aren't numbers, but it has special handling
> to turn empty defines (or the number 1) into an unquoted y.

Yes, this works as well. I'll send an updated patch tomorrow.

Thanks.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de