From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/1] net: fix some bugs in LL TEMAC driver
Date: Sun, 28 Nov 2010 21:35:58 +0100 [thread overview]
Message-ID: <20101128203558.035181352CD@gemini.denx.de> (raw)
In-Reply-To: <1290419192-13422-2-git-send-email-linz@li-pro.net>
Dear Stephan Linz,
In message <1290419192-13422-2-git-send-email-linz@li-pro.net> you wrote:
> * avoid using link variable uninitialized
> * avoid using phy_addr variable with invalid value
> * reorganize phy control: first looking for phy than link
> * return with error (result value 0) if no phy/link was found
> * fix boolean mistake in wait for link: wait as long as we got
> phy register 1 has no link indication (BMSR != 0x24)
> * expand the 'first run' flag handling in ll_temac_init() in
> respect to possible error detection in xps_ll_temac_phy_ctrl()
>
> Signed-off-by: Stephan Linz <linz@li-pro.net>
> ---
> drivers/net/xilinx_ll_temac.c | 52 ++++++++++++++++++++++++++++++-----------
> 1 files changed, 38 insertions(+), 14 deletions(-)
Please merges these fixzes into the next submission of the LL TEMAC
driver.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A committee is a life form with six or more legs and no brain.
-- Lazarus Long, "Time Enough For Love"
next prev parent reply other threads:[~2010-11-28 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 18:54 [U-Boot] [PATCH 1/2] net: fix some bugs in LL TEMAC driver Stephan Linz
2010-11-19 18:54 ` [U-Boot] [PATCH 2/2] net: Add National DP83865 PHY to " Stephan Linz
2010-11-20 9:23 ` Michal Simek
2010-11-20 18:48 ` Stephan Linz
2010-11-20 9:27 ` [U-Boot] [PATCH 1/2] net: fix some bugs in " Michal Simek
2010-11-20 18:48 ` Stephan Linz
2010-11-22 9:46 ` [U-Boot] corrections for LL TEMAC bug fixing Stephan Linz
2010-11-22 9:46 ` [U-Boot] [PATCH V2 1/1] net: fix some bugs in LL TEMAC driver Stephan Linz
2010-11-28 20:35 ` Wolfgang Denk [this message]
2010-11-29 11:06 ` Stephan Linz
2010-12-03 8:48 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128203558.035181352CD@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox