From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Linz Date: Mon, 29 Nov 2010 12:06:13 +0100 Subject: [U-Boot] [PATCH V2 1/1] net: fix some bugs in LL TEMAC driver In-Reply-To: <20101128203558.035181352CD@gemini.denx.de> References: <66901067543efe59d87b3a805a4b19ce52a780c5.1290192590.git.linz@li-pro.net> <1290419192-13422-2-git-send-email-linz@li-pro.net> <20101128203558.035181352CD@gemini.denx.de> Message-ID: <201011291206.13885.linz@li-pro.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am Sonntag, 28. November 2010, um 21:35:58 schrieb Wolfgang Denk: > Dear Stephan Linz, Hello Wolfgang Denk, > > In message <1290419192-13422-2-git-send-email-linz@li-pro.net> you wrote: > > * avoid using link variable uninitialized > > * avoid using phy_addr variable with invalid value > > * reorganize phy control: first looking for phy than link > > * return with error (result value 0) if no phy/link was found > > * fix boolean mistake in wait for link: wait as long as we got > > phy register 1 has no link indication (BMSR != 0x24) > > * expand the 'first run' flag handling in ll_temac_init() in > > respect to possible error detection in xps_ll_temac_phy_ctrl() > > > > Signed-off-by: Stephan Linz > > --- > > drivers/net/xilinx_ll_temac.c | 52 > > ++++++++++++++++++++++++++++++----------- 1 files changed, 38 > > insertions(+), 14 deletions(-) > > Please merges these fixzes into the next submission of the LL TEMAC > driver. Sure, I will maintain this patchset until I get Michal's ACK and/or he will merge the corrections into the next LL TEMAC driver submission. I'm in contact with him. Best regards, Stephan Linz