public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] omap3evm: Clean-up EVM detection code.
Date: Thu, 02 Dec 2010 14:58:04 +0100	[thread overview]
Message-ID: <20101202135804.3BACFEA6600@gemini.denx.de> (raw)
In-Reply-To: <4CF7922B.3020504@free.fr>

Dear Albert ARIBAUD,

In message <4CF7922B.3020504@free.fr> you wrote:
>
> Now, on an unrelated note, omap3_emv's code arbitrarily uses an u8 where 
> an int (or enum) would be more appropriate, and this should be changed 
> not because it removes a linker warning, but because the u8 choice is 
> arbitrary and at best as effective as using an int, at worst suboptimal 
> to that.

Well, an u8 is as good a data type as any other. The available range
of 0...255 seems more than sufficient to store the needed
information, so why should I waste 4 bytes of storage when a single
byte is sufficient as well?



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You know, after a woman's raised a family and so on,  she  wants  to
start living her own life."   "Whose life she's _been_ living, then?"
                                  - Terry Pratchett, _Witches Abroad_

  reply	other threads:[~2010-12-02 13:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02 11:20 [U-Boot] [PATCH] omap3evm: Clean-up EVM detection code Sanjeev Premi
2010-12-02 11:37 ` Wolfgang Denk
2010-12-02 11:56   ` Albert ARIBAUD
2010-12-02 12:01     ` Wolfgang Denk
2010-12-02 12:33       ` Albert ARIBAUD
2010-12-02 13:58         ` Wolfgang Denk [this message]
2010-12-02 16:23           ` Albert ARIBAUD
2010-12-02 18:51             ` Wolfgang Denk
2010-12-02 19:32               ` Albert ARIBAUD
2010-12-02 13:30   ` Premi, Sanjeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101202135804.3BACFEA6600@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox