[U-Boot] [PATCH] Honor /memory/reg node in DTB files

Deepak Saxena
2010-12-08T18:59:44Z

On 12/07/2010 01:22 PM, Scott Wood wrote:
> On Mon, 6 Dec 2010 16:56:26 -0800
> Deepak Saxena <deepak_saxena@mentor.com> wrote:
>
>> +/*
>> + * Check to see if an valid memory/reg property exists
>> + * in the fdt. If so, we do not overwrite it with what's
>> + * been scanned.
>> + *
>> + * Valid mean all the following:
>> + *
>> + * - Memory node has a device-type of "memory"
>> + * - A reg property exists which:
>> + * + has exactly as many cells as #address-cells + #size-cells
>> + * + provides a range that is within [bi_memstart, bi_memstart +
>> bi_memsize]
>> + */
>
> This will get false positives -- a lot of existing device tree
> templates have something like this:

ACK. The code in the patch actually checks for this, just didn't point
it out in the comments.

~deepak