From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] armv7: start.S: Fix relocation address caculation
Date: Thu, 16 Dec 2010 13:20:34 +0100 [thread overview]
Message-ID: <20101216122034.EB519BB0BA@gemini.denx.de> (raw)
In-Reply-To: <AANLkTik=BSaBbV-NOJYg2QXx0Q-YYK4=Ox3iF8dWR5re@mail.gmail.com>
Dear Jason Liu,
In message <AANLkTik=BSaBbV-NOJYg2QXx0Q-YYK4=Ox3iF8dWR5re@mail.gmail.com> you wrote:
>
> In fact, this is indeed one bug in the code as I said in the comit log:
>
> "the _dynsym_start_ofs and _rel_dyn_start_ofs is the
> offset from _start, so, need use _start address instead
> of _TEXT_BASE to caculate the rel dyn start and sym table
> address. This patch also correct the board_init_r function
> address caculation in relocation area. The addr of board_init_r
> after relocation is: _board_init_r_offs + relocation start address."
If there are really two different bugs, then please split your patch
into to separate commits, and explain the respective problem in the
commit messages.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A modem is a baudy house.
next prev parent reply other threads:[~2010-12-16 12:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 13:57 [U-Boot] [PATCH 1/1] armv7: start.S: Fix relocation address caculation Jason Liu
2010-12-15 17:06 ` Albert ARIBAUD
2010-12-16 3:04 ` Jason Liu
2010-12-16 9:04 ` Albert ARIBAUD
2010-12-16 9:18 ` Jason Liu
2010-12-16 9:58 ` Albert ARIBAUD
2010-12-16 10:09 ` Wolfgang Denk
2010-12-16 10:22 ` Jason Liu
2010-12-16 12:20 ` Wolfgang Denk [this message]
2010-12-16 9:53 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216122034.EB519BB0BA@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox