From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] MX5:MX53: add initial support for MX53EVK board
Date: Fri, 17 Dec 2010 00:04:58 +0100 [thread overview]
Message-ID: <20101216230458.3210FD1CAB9@gemini.denx.de> (raw)
In-Reply-To: <1292494665-25674-6-git-send-email-r64343@freescale.com>
Dear Jason Liu,
In message <1292494665-25674-6-git-send-email-r64343@freescale.com> you wrote:
> Add initial support for MX53EVK board support.
> FEC, SD/MMC, UART, I2C, have been support.
>
> Signed-off-by: Jason Liu <r64343@freescale.com>
The following is in addition to previously made comments:
> --- /dev/null
> +++ b/board/freescale/mx53evk/config.mk
Drop that file.
> +CONFIG_SYS_TEXT_BASE = 0x77800000
This goes to the board config file instead.
> +/* size in bytes reserved for initial data */
> +#define BOARD_LATE_INIT
Seems to be a bogus comment?
> +/*
> + * Hardware drivers
> + */
What exactly are "Hardware drivers" ?
> +#define CONFIG_SYS_MEMTEST_START 0x70000000
> +#define CONFIG_SYS_MEMTEST_END 0x10000
Please say - has this ever been tested?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Put your Nose to the Grindstone!
-- Amalgamated Plastic Surgeons and Toolmakers, Ltd.
next prev parent reply other threads:[~2010-12-16 23:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 10:17 [U-Boot] [PATCH 0/5] Add support for Freescale MX53 Jason Liu
2010-12-16 10:17 ` [U-Boot] [PATCH 1/5] MX5: Add initial support for MX53 Jason Liu
2010-12-16 12:27 ` Wolfgang Denk
2010-12-17 3:20 ` Jason Liu
2010-12-16 13:34 ` Stefano Babic
2010-12-17 3:18 ` Jason Liu
2010-12-16 10:17 ` [U-Boot] [PATCH 2/5] serial_mxc: add support for MX53 processor Jason Liu
2010-12-16 10:17 ` [U-Boot] [PATCH 3/5] fec_mxc: " Jason Liu
2010-12-16 10:17 ` [U-Boot] [PATCH 4/5] mxc_i2c: " Jason Liu
2010-12-16 10:37 ` Heiko Schocher
2010-12-17 3:28 ` Jason Liu
2010-12-16 10:17 ` [U-Boot] [PATCH 5/5] MX5:MX53: add initial support for MX53EVK board Jason Liu
2010-12-16 10:48 ` Albert ARIBAUD
2010-12-16 12:23 ` Wolfgang Denk
2010-12-16 13:19 ` Stefano Babic
2010-12-17 3:05 ` Jason Liu
2010-12-17 5:41 ` Wolfgang Denk
2010-12-17 10:20 ` Albert ARIBAUD
2010-12-17 13:05 ` Stefano Babic
2010-12-20 5:19 ` Jason Liu
2010-12-20 6:52 ` John Rigby
2010-12-22 13:40 ` Jason Liu
2010-12-27 10:03 ` Stefano Babic
2010-12-20 6:52 ` Albert ARIBAUD
2010-12-16 23:04 ` Wolfgang Denk [this message]
2010-12-17 3:04 ` Jason Liu
2010-12-17 5:36 ` Wolfgang Denk
2010-12-16 12:25 ` [U-Boot] [PATCH 0/5] Add support for Freescale MX53 Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216230458.3210FD1CAB9@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox