public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Add support for XZ decompression algorithm.
Date: Fri, 17 Dec 2010 21:00:28 +0100	[thread overview]
Message-ID: <20101217200028.C2CD515192A@gemini.denx.de> (raw)
In-Reply-To: <1291562184-27126-1-git-send-email-luigi.mantellini@idf-hit.com>

Dear Luigi 'Comio' Mantellini,

In message <1291562184-27126-1-git-send-email-luigi.mantellini@idf-hit.com> you wrote:
> XZ (aka LZMA2) is the new version of lzma compression format.
> The following patch add a cut-down version of XZ Embedded library (v20100702)
> that supports only single-call API.
> 
> In order to enable XZ support, the CONFIG_XZ must be defined by board
> configuration file.
> 
> For any details, please refer to XZ Embedded homesite
> (http://tukaani.org/xz/embedded.html)
...
> @@ -1178,6 +1179,14 @@ The following options need to be configured:
>  		then calculate the amount of needed dynamic memory (ensuring
>  		the appropriate CONFIG_SYS_MALLOC_LEN value).
>  
> +		CONFIG_XZ
> +
> +		If this option is set, support for xz compresed
> +		images is included.
> +
> +		XZ format is the next version of LZMA format. See also
> +		the CONFIG_LZMA

s/compresed/compressed/

> +/*
> + * Use the internal CRC32 code instead of kernel's CRC32 module, which
> + * is not available in early phase of booting.
> + */
> +#define XZ_INTERNAL_CRC32 1

This has already caused confusion, but appears to be unused.

Please clean up the code not to contain such dead definitions.


I did not see a reply yet to the request to deprecate CONFIG_LZMA and
have the new CONFIG_XZ support handle both .xz and .lzma archives?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There has been an alarming increase in the number of things you  know
nothing about.

      parent reply	other threads:[~2010-12-17 20:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-05 15:16 [U-Boot] [PATCH 1/2] Add support for XZ decompression algorithm Luigi 'Comio' Mantellini
2010-12-05 15:16 ` [U-Boot] [PATCH 2/2] Add XZ compressed uImage support Luigi 'Comio' Mantellini
2010-12-06 17:44 ` [U-Boot] [PATCH 1/2] Add support for XZ decompression algorithm Joakim Tjernlund
2010-12-06 17:58 ` Peter Tyser
2010-12-06 18:06   ` Mike Frysinger
2010-12-06 22:52     ` Luigi Mantellini
2010-12-06 23:12       ` Wolfgang Denk
2010-12-17 20:00 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101217200028.C2CD515192A@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox