From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Lo=EFc?= Minier <lool@dooz.org>
Date: Sat, 18 Dec 2010 17:07:11 +0100
Subject: [U-Boot] [PATCH] Don't add symlink in srctree when using an
 objtree
In-Reply-To: <20101217195131.321CC15192A@gemini.denx.de>
References: <1291510334-650-1-git-send-email-loic.minier@linaro.org>
	<20101217195131.321CC15192A@gemini.denx.de>
Message-ID: <20101218160711.GA4008@bee.dooz.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Dec 17, 2010, Wolfgang Denk wrote:
> Thanks for the fix.  A tiny change request, though:
> > -	@rm -f $(obj)include/asm/proc $(obj)include/asm/arch $(obj)include/asm
> > +	@rm -f $(obj)include/asm/proc $(obj)include/asm/arch
> > +	@[ ! -h $(obj)include/asm ] || rm -f $(obj)include/asm
> > +	@[ ! -d $(obj)include/asm ] || rmdir $(obj)include/asm
> 
> Don't make it that complicated. Just change the line into
> 	@rm -fr$(obj)include/asm/proc $(obj)include/asm/arch $(obj)include/asm

 I think I had this in my first version, but had an issue with it; I
 will retest

> Also a question: how has this change been tested?

 I did something like:
 a) start fresh:
   git clean -x -d
 b) configure with or without objdir
    make CROSS_COMPILE=arm-linux-gnueabi- O=$PWD/obj omap3_beagle_config
 c) build (with or without objdir)
 d) distclean (with or without objdir)

 and tested combinations like a-d-d, a-b-d-d, a-b-c-d-d, then checked
 whether any file remained with git clean -x -d -n

-- 
Lo?c Minier