[U-Boot] [PATCH v2] Blackfin: dnp5370: new board port

[Mike Frysinger <vapier@gentoo.org>]

On Sunday, December 19, 2010 07:27:05 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -1090,6 +1090,10 @@ Peter Meerwald <devel@bct-electronic.com>
> > > > 
> > > >  	bct-brettl2	BF536
> > > > 
> > > > +M.Hasewinkel (MHA) <info@ssv-embedded.de>
> > > > +
> > > > +	dnp5370		BF537
> > > 
> > > Please keep list sorted.
> > 
> > the list is already not sorted, nor is it really feasible to do so.  it's
> > grouped by maintainer which may have multiply named boards.
> 
> If you don't want to help to clean up (which I can live with), then
> please at least do not add to the mess.

i'm saying that if the list cant be sorted, then there isnt a mess and there 
isnt anything to "clean up"

> > > > +#define CONFIG_IPADDR          10.100.100.21
> > > > +#define CONFIG_NETMASK         255.255.0.0
> > > > +#define CONFIG_GATEWAYIP       10.100.100.1
> > > > +#define CONFIG_SERVERIP        10.100.100.12
> > > 
> > > NAK.  We do not allow this.
> > 
> > i dont see why.  these are *default* settings.  there is nothing here
> > that prevents people in their own board from overriding at runtime and
> > saving the result into their environment.  where as having default
> > settings often makes new builds/tests a lot smoother.
> 
> It's still NAK.

so the logic here is "because i said so"
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101219/a313b1db/attachment.pgp