public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Move DECLARE_GLOBAL_DATA_PTR to file scope
Date: Tue, 21 Dec 2010 09:07:14 +0100	[thread overview]
Message-ID: <20101221080714.6FBA5B715C@gemini.denx.de> (raw)
In-Reply-To: <1292894871-1436-1-git-send-email-john.rigby@linaro.org>

Dear John Rigby,

In message <1292894871-1436-1-git-send-email-john.rigby@linaro.org> you wrote:
> It can be optimised out by the compiler otherwise resulting
> in obscure errors like a board not booting.
> 
> This has been documented in README since 2006 when these were
> first fixed up for GCC 4.x.
> 
> Signed-off-by: John Rigby <john.rigby@linaro.org>

Thanks for the cleanup.  Much appreciated.

However, this patch appears to miss a few places.  I think we should
additionally change the following:

  parent reply	other threads:[~2010-12-21  8:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-21  1:27 [U-Boot] [PATCH] Move DECLARE_GLOBAL_DATA_PTR to file scope John Rigby
2010-12-21  6:17 ` Albert ARIBAUD
2010-12-21  8:07   ` Wolfgang Denk
2010-12-21  8:27     ` Albert ARIBAUD
2010-12-21  8:07 ` Wolfgang Denk [this message]
2010-12-21 19:25 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101221080714.6FBA5B715C@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox