From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] spi: add spi_set_speed func
Date: Fri, 24 Dec 2010 12:09:17 -0500 [thread overview]
Message-ID: <201012241209.18236.vapier@gentoo.org> (raw)
In-Reply-To: <1293174969-18653-3-git-send-email-thomas@wytron.com.tw>
On Friday, December 24, 2010 02:16:07 Thomas Chou wrote:
> --- /dev/null
> +++ b/drivers/spi/spi.c
> @@ -0,0 +1,9 @@
> +#include <common.h>
> +#include <spi.h>
> +
> +/* default func for SPI driver without set speed func */
> +static void __spi_set_speed(struct spi_slave *slave, uint hz)
> +{
> +}
> +void spi_set_speed(struct spi_slave *slave, uint hz)
> + __attribute__((weak, alias("__spi_set_speed")));
let's not go this route. just add the prototype to the header and when the
respective spi bus maintainer wants to support this new func, they can
implement it. i'd rather people know about the problem up front rather than
have things randomly not work.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101224/9999498e/attachment.pgp
next prev parent reply other threads:[~2010-12-24 17:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-24 7:16 [U-Boot] [PATCH 0/4] generic mmc_spi driver Thomas Chou
2010-12-24 7:16 ` [U-Boot] [PATCH 1/4] lib: add crc7 from Linux Thomas Chou
2011-01-10 20:59 ` Wolfgang Denk
2011-01-11 1:38 ` [U-Boot] [PATCH v2] " Thomas Chou
2011-01-18 22:38 ` Wolfgang Denk
2010-12-24 7:16 ` [U-Boot] [PATCH 2/4] spi: add spi_set_speed func Thomas Chou
2010-12-24 17:09 ` Mike Frysinger [this message]
2010-12-24 23:13 ` [U-Boot] [PATCH 2/4 v2] " Thomas Chou
2011-01-18 22:37 ` Wolfgang Denk
2011-01-19 1:34 ` [U-Boot] [PATCH 2/4 v3] " Thomas Chou
2010-12-24 7:16 ` [U-Boot] [PATCH 3/4] bfin_spi: add spi_set_speed Thomas Chou
2010-12-24 17:25 ` Mike Frysinger
2010-12-24 7:16 ` [U-Boot] [PATCH 4/4] mmc: add generic mmc spi driver Thomas Chou
2010-12-24 23:12 ` [U-Boot] [PATCH 4/4 v10] " Thomas Chou
2010-12-24 17:24 ` [U-Boot] [PATCH 0/4] generic mmc_spi driver Mike Frysinger
2010-12-24 19:06 ` Reinhard Meyer
2010-12-24 19:45 ` Mike Frysinger
2010-12-24 23:21 ` Thomas Chou
2011-04-12 6:58 ` Mike Frysinger
2011-04-13 10:17 ` Andy Fleming
2011-04-13 19:46 ` Mike Frysinger
2011-04-18 7:00 ` [U-Boot] [PATCH] mmc_spi: add mmc_init call Thomas Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012241209.18236.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox