public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add LDFLAGS-u-boot variable and move some linker option to this
Date: Mon, 27 Dec 2010 11:46:21 -0500	[thread overview]
Message-ID: <201012271146.22205.vapier@gentoo.org> (raw)
In-Reply-To: <20101227104754.7AD6D152438@gemini.denx.de>

On Monday, December 27, 2010 05:47:54 Wolfgang Denk wrote:
> Nobuhiro Iwamatsu wrote:
> > This move linker option used by the last of u-boot in LDFLAGS_u-boot
> > variable. And the option to use in ld uses LDFLAGS variable.
> 
> Can you please explain why this would be needed?

he explained in the previous thread why we need to split things.  there are 
flags that are needed for all linker options and there are flags needed just 
for the final u-boot link.

> > -LDFLAGS += --gc-sections -m elf32bfin
> > +LDFLAGS_u-boot += --gc-sections
> 
> The name "LDFLAGS_u-boot" may actually work here, but iut is
> inconsistent with other such variables names, and using '-' in a name
> is probably not a good idea either.

it isnt inconsistent.  the convention is $(XFLAGS_$(@F)) and we just happen to 
be creating a file here which is named "u-boot".  dashes in variable names 
isnt a problem for make.  otherwise you're basically banning creating files in 
the u-boot tree with dashes in their filenames.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101227/c9d76dcf/attachment.pgp 

  reply	other threads:[~2010-12-27 16:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-27  7:00 [U-Boot] [PATCH] Add LDFLAGS-u-boot variable and move some linker option to this Nobuhiro Iwamatsu
2010-12-27 10:47 ` Wolfgang Denk
2010-12-27 16:46   ` Mike Frysinger [this message]
2010-12-27 18:58     ` Wolfgang Denk
2010-12-27 20:11       ` Mike Frysinger
2010-12-27 23:23         ` Wolfgang Denk
2010-12-28  1:00           ` Mike Frysinger
2010-12-30  2:02 ` Mike Frysinger
2011-01-05  6:52   ` Nobuhiro Iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201012271146.22205.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox