From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/9] make the hwconfig buffer deeper
Date: Fri, 07 Jan 2011 18:50:55 +0100 [thread overview]
Message-ID: <20110107175055.992F62FC@gemini.denx.de> (raw)
In-Reply-To: <740DF509-6661-4611-BE1B-BBB629012697@kernel.crashing.org>
Dear Kumar Gala,
In message <740DF509-6661-4611-BE1B-BBB629012697@kernel.crashing.org> you wrote:
>
> >> Making a buffer in a function's stack and make use of it out of the
> >> scope, that's the buggy code I am referring.
> >
> > That is bad indeed, and needs to be fixed.
>
> Where is that happening?
__hwconfig() calls hwconfig_parse() an passes a local stack buffer
(buf) as argument; hwconfig_parse() returns a pointer into this
buffer; then __hwconfig() returns the return value from
hwconfig_parse() - but here the local stack buffer gots out of scope.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Make it right before you make it faster.
next prev parent reply other threads:[~2011-01-07 17:50 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 23:59 [U-Boot] [PATCH v2 1/9] mpc8xxx: Display RDIMM if detected York Sun
2010-12-17 23:59 ` [U-Boot] [PATCH v2 2/9] make the hwconfig buffer deeper York Sun
2010-12-18 22:25 ` Wolfgang Denk
2011-01-03 20:08 ` York Sun
2011-01-03 21:11 ` Wolfgang Denk
2011-01-03 21:26 ` York Sun
2011-01-03 21:47 ` Wolfgang Denk
2011-01-07 15:14 ` Kumar Gala
2011-01-07 16:49 ` York Sun
2011-01-07 17:52 ` Wolfgang Denk
2011-01-07 23:23 ` Kumar Gala
2011-01-09 21:00 ` Kumar Gala
2011-01-10 18:39 ` York Sun
2011-01-07 17:50 ` Wolfgang Denk [this message]
2010-12-17 23:59 ` [U-Boot] [PATCH v2 3/9] mpc8xxx: Enable ECC on/off control in hwconfig York Sun
2011-01-09 21:23 ` Kumar Gala
2010-12-17 23:59 ` [U-Boot] [PATCH v2 4/9] corenet_ds: Enable ECC for corenet_ds York Sun
2010-12-17 23:59 ` [U-Boot] [PATCH v2 5/9] mpc85xx: Adding more registers and options York Sun
2010-12-18 22:30 ` Wolfgang Denk
2010-12-17 23:59 ` [U-Boot] [PATCH v2 6/9] mpc85xx: Enable unique mode registers and dynamic ODT for DDR3 York Sun
2010-12-18 22:53 ` Wolfgang Denk
2010-12-17 23:59 ` [U-Boot] [PATCH v2 7/9] Adding more SPD registers York Sun
2010-12-18 22:54 ` Wolfgang Denk
2010-12-17 23:59 ` [U-Boot] [PATCH v2 8/9] mpc85xx: Implement workaround for erratum DDR-A003 York Sun
2011-01-09 21:23 ` Kumar Gala
2010-12-17 23:59 ` [U-Boot] [PATCH v2 9/9] corenet_ds: Extend board specific parameters York Sun
2010-12-18 22:20 ` Wolfgang Denk
2010-12-18 22:21 ` [U-Boot] [PATCH v2 1/9] mpc8xxx: Display RDIMM if detected Wolfgang Denk
2010-12-21 13:36 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107175055.992F62FC@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox