From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] ARM: print gcc version
Date: Sun, 09 Jan 2011 22:03:00 +0100 [thread overview]
Message-ID: <20110109210300.B2CD3127@gemini.denx.de> (raw)
In-Reply-To: <1292863117-3175-1-git-send-email-holler@ahsoftware.de>
Dear Alexander Holler,
In message <1292863117-3175-1-git-send-email-holler@ahsoftware.de> you wrote:
> It might be useful to see what compiler version was used to compile u-boot.
> ---
> arch/arm/lib/board.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 96c0e30..df90b5e 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -75,7 +75,7 @@ extern void dataflash_print_info(void);
> #endif
>
> const char version_string[] =
> - U_BOOT_VERSION" (" U_BOOT_DATE " - " U_BOOT_TIME ")"CONFIG_IDENT_STRING;
> + U_BOOT_VERSION" (" U_BOOT_DATE " - " U_BOOT_TIME ", gcc " __VERSION__ ")"CONFIG_IDENT_STRING;
I understand your intention, but I'm not really happy with it.
So far, the version_string is mostly architecture and system independent.
I haven't seen any comments about this, but I can imagine that we want
such information globally.
On the other hand, that would require changes to many files, and the
gcc __VERSION__ string is pretty long on some systems, which may cause
additional problems.
I also doubt that we need this information with each boot message
(where it just slows down booting).
Would it not be sufficient to add this to the code of do_version() so
we can get this information when we want it, i. e. when running the
"version" command?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As long as we're going to reinvent the wheel again, we might as well
try making it round this time. - Mike Dennison
next prev parent reply other threads:[~2011-01-09 21:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 16:38 [U-Boot] [RFC PATCH] ARM: print gcc version Alexander Holler
2011-01-09 21:03 ` Wolfgang Denk [this message]
2011-01-11 2:00 ` Alexander Holler
2011-01-17 22:28 ` Wolfgang Denk
2011-01-18 9:16 ` Alexander Holler
2011-01-18 16:20 ` Peter Tyser
2011-01-18 17:04 ` Alexander Holler
2011-01-18 19:53 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109210300.B2CD3127@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox