From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 09 Jan 2011 22:03:00 +0100 Subject: [U-Boot] [RFC PATCH] ARM: print gcc version In-Reply-To: <1292863117-3175-1-git-send-email-holler@ahsoftware.de> References: <1292863117-3175-1-git-send-email-holler@ahsoftware.de> Message-ID: <20110109210300.B2CD3127@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Alexander Holler, In message <1292863117-3175-1-git-send-email-holler@ahsoftware.de> you wrote: > It might be useful to see what compiler version was used to compile u-boot. > --- > arch/arm/lib/board.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c > index 96c0e30..df90b5e 100644 > --- a/arch/arm/lib/board.c > +++ b/arch/arm/lib/board.c > @@ -75,7 +75,7 @@ extern void dataflash_print_info(void); > #endif > > const char version_string[] = > - U_BOOT_VERSION" (" U_BOOT_DATE " - " U_BOOT_TIME ")"CONFIG_IDENT_STRING; > + U_BOOT_VERSION" (" U_BOOT_DATE " - " U_BOOT_TIME ", gcc " __VERSION__ ")"CONFIG_IDENT_STRING; I understand your intention, but I'm not really happy with it. So far, the version_string is mostly architecture and system independent. I haven't seen any comments about this, but I can imagine that we want such information globally. On the other hand, that would require changes to many files, and the gcc __VERSION__ string is pretty long on some systems, which may cause additional problems. I also doubt that we need this information with each boot message (where it just slows down booting). Would it not be sufficient to add this to the code of do_version() so we can get this information when we want it, i. e. when running the "version" command? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de As long as we're going to reinvent the wheel again, we might as well try making it round this time. - Mike Dennison