public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] update VCMA9 port
Date: Sun, 09 Jan 2011 22:24:35 +0100	[thread overview]
Message-ID: <20110109212435.B5C90127@gemini.denx.de> (raw)
In-Reply-To: <1292926154-19802-1-git-send-email-d.mueller@elsoft.ch>

Dear =?UTF-8?q?David=20M=C3=BCller?=,

In message <1292926154-19802-1-git-send-email-d.mueller@elsoft.ch> you wrote:
> 
> This patch brings the VCMA9 port in sync with the latest U-Boot
> version by doing the following:
>  - do the necessary adjustments to support the ARM relocation feature
>  - use the CFI flash driver (and removing the old one)
>  - various cleanups and coding style fixes
...
> diff --git a/board/mpl/vcma9/config.mk b/board/mpl/vcma9/config.mk
> index e345913..fef5308 100644
> --- a/board/mpl/vcma9/config.mk
> +++ b/board/mpl/vcma9/config.mk
...
> -#CONFIG_SYS_TEXT_BASE = 0x30F80000
> -CONFIG_SYS_TEXT_BASE = 0x33F80000
> +CONFIG_SYS_TEXT_BASE = 0x0

Please move this line into your board config file, and drop the
config.mk file.

> diff --git a/board/mpl/vcma9/lowlevel_init.S b/board/mpl/vcma9/lowlevel_init.S
> index 062e868..cb1518b 100644
> --- a/board/mpl/vcma9/lowlevel_init.S
> +++ b/board/mpl/vcma9/lowlevel_init.S
> @@ -4,9 +4,9 @@
>   * Copyright (C) 1999 2000 2001 Erik Mouw (J.A.K.Mouw at its.tudelft.nl) and
>   *                     Jan-Derk Bakker (J.D.Bakker at its.tudelft.nl)
>   *
> - * Modified for the Samsung SMDK2410 by
> - * (C) Copyright 2002

I understand this file was created using copy & paste; why do you
think it is legal to remove the original copyright notice?

> + * Modified for MPL VCMA9 by
>   * David Mueller, ELSOFT AG, <d.mueller@elsoft.ch>

We don't need this here. This information is present in the commit
logs.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You Don't Have To Be 'Damned' To Work Here, But It Helps!!!
                                             - Terry Pratchett, _Eric_

  reply	other threads:[~2011-01-09 21:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-21 10:09 [U-Boot] [PATCH] update VCMA9 port David Müller
2011-01-09 21:24 ` Wolfgang Denk [this message]
2011-01-10  8:13   ` "David Müller (ELSOFT AG)"
2011-01-11  7:47 ` [U-Boot] [PATCH V2] " David Müller
2011-01-11  9:36   ` Wolfgang Denk
2011-01-11 12:22 ` [U-Boot] [PATCH V3] " David Müller
2011-02-01  8:35   ` [U-Boot] [PING] " "David Müller (ELSOFT AG)"
2011-03-01  8:00   ` [U-Boot] [PING #2] " "David Müller (ELSOFT AG)"
2011-03-02  2:28   ` [U-Boot] " Minkyu Kang
2011-04-11 19:24     ` Wolfgang Denk
2011-04-12  1:21       ` Minkyu Kang
2011-04-12  9:32 ` [U-Boot] [PATCH V4] " David Müller
2011-04-12  9:32 ` [U-Boot] [PATCH V4 1/4] VCMA9: activate ARM relocation feature David Müller
2011-04-12 10:30   ` Wolfgang Denk
2011-04-12 10:32   ` Wolfgang Denk
2011-04-12  9:32 ` [U-Boot] [PATCH V4 2/4] VCMA9: remove unneeded config.mk David Müller
2011-04-12  9:32 ` [U-Boot] [PATCH V4 3/4] VCMA9: use the CFI driver (and remove the old one) David Müller
2011-04-12  9:32 ` [U-Boot] [PATCH V4 4/4] VCMA9: various cleanups/code style fixes David Müller
2011-04-12 10:28   ` Wolfgang Denk
2011-05-02  7:52 ` [U-Boot] [PATCH V5 0/4] update VCMA9 port David Müller
2011-05-02  7:52 ` [U-Boot] [PATCH V5 1/4] VCMA9: use ARM relocation feature to fix build error David Müller
2011-05-02  7:52 ` [U-Boot] [PATCH V5 2/4] VCMA9: remove unneeded config.mk David Müller
2011-05-02  7:52 ` [U-Boot] [PATCH V5 3/4] VCMA9: use CFI driver (and remove the old one) David Müller
2011-05-02  7:52 ` [U-Boot] [PATCH V5 4/4] VCMA9: various cleanups/code style fixes David Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110109212435.B5C90127@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox