From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] iMX5: EfikaMX: Work-in-progress board support
Date: Tue, 18 Jan 2011 20:31:25 +0100 [thread overview]
Message-ID: <201101182031.25837.marek.vasut@gmail.com> (raw)
In-Reply-To: <4D2F3A5A.5010608@denx.de>
On Thursday 13 January 2011 18:46:02 Stefano Babic wrote:
> On 01/13/2011 06:15 PM, Marek Vasut wrote:
> >>> + mxc_request_iomux(MX51_PIN_NANDF_RB3, IOMUX_CONFIG_GPIO);
> >>> + mxc_iomux_set_pad(MX51_PIN_NANDF_RB3, PAD_CTL_100K_PU);
> >>> + mxc_gpio_direction(IOMUX_TO_GPIO(MX51_PIN_NANDF_RB3),
> >>> MXC_GPIO_DIRECTION_IN); + rev |=
> >>> (!!mxc_gpio_get(IOMUX_TO_GPIO(MX51_PIN_NANDF_RB3))) << 2;
> >>
> >> Is it ok to leave the NAND pins configured as GPIO, or should they set
> >> back for the NFC controller ?
> >
> > I don't think there is even NAND used on efikamx. Though I might be
> > mistaken.
>
> Understood, then I agree to leave the iomux set with gpios.
>
> >> Replace fix constants with defines, adding them to mc13892.h if they are
> >> missing.
> >
> > Is any sane datasheet for this thing available ? If so, can you link me
> > to it please?
>
> There is a datasheet, I do not know if you can consider it "sane" ;-)
>
> http://cache.freescale.com/files/analog/doc/data_sheet/MC13892.pdf?fpsp=1
>
> The register description is quite spread in the manual. You can see the
> complete SPI Bitmap on pages 118-121.
>
> I have already set most constants in include/mc13892.h, probably there
> are some missing.
>
> >>> +#define __io
> >>
> >> I think we have already discussed abot this define. Should it not move
> >> to another file, such as imx-regs.h ? Or is there a better solution ?
> >
> > The thread where we discussed this got deaf. I tried asking further, but
> > no reply :-(
>
> Agree, I remember the issue, I do not remember any decision. Anyway, I
> think the position of this macro is wrong. It is related to the
> processor, that can have it or not, and it is not related to the board.
> I see that in u-boot __io is defined in board configuration file, but I
> do not think it is correct.
>
> At least I will suggest to move this define in the processor related
> file (-->imx-regs.h).
This is a problem, if __io is defined there, it won't be defined in the ide
driver.
>
> Cheers,
> Stefano
next prev parent reply other threads:[~2011-01-18 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 22:46 [U-Boot] [PATCH 1/2] BLOCK: Add freescale IMX51 PATA driver Marek Vasut
2011-01-12 22:46 ` [U-Boot] [PATCH 2/2] iMX5: EfikaMX: Work-in-progress board support Marek Vasut
2011-01-13 9:37 ` Stefano Babic
2011-01-13 17:15 ` Marek Vasut
2011-01-13 17:46 ` Stefano Babic
2011-01-18 19:31 ` Marek Vasut [this message]
2011-01-13 8:55 ` [U-Boot] [PATCH 1/2] BLOCK: Add freescale IMX51 PATA driver Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101182031.25837.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox