public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marcel <korgull@home.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] NetRxPackets
Date: Wed, 19 Jan 2011 00:27:27 +0100	[thread overview]
Message-ID: <201101190027.28425.korgull@home.nl> (raw)
In-Reply-To: <4D361A1E.1000909@emk-elektronik.de>

On Tuesday, January 18, 2011 11:54:22 pm Reinhard Meyer wrote:
> Dear Marcel,
> 
> >> Well,you're supposed to do some basic code reading yourself.
> > 
> > Of course. It's always the idea to post a question after reading for some
> > time. It either means I don't understand the code, the code really
> > doesn't work or I did miss the most important part in the documents. I
> > guess the answer will follow once the issue is solved.
> > To be specific, I work with the u-boot-usb at91-cdc branch code. I'm not
> > sure if that is all working code at this moment but sounded like the
> > best starting point for my USB code.
> 
> Not sure that branch is anything up to date....

hmmm.  What branch is best to work on for this code ?
 
> >>> req->buf = (u8 *) NetRxPackets[0];
> 
> *maybe* "req" itself is not allocated?

Good question. My code that rejects the buffer is this :

static int
usba_ep_queue(struct usb_ep *_ep, 
              struct usb_request *_req, 
              gfp_t gfp_flags)
{
        struct usba_request *req = container_of(_req, struct usba_request, 
req);
        struct usba_ep *ep = container_of(_ep, struct usba_ep, ep);
        struct usba_udc *udc = ep->udc;
        int ret;
        
        debug("%s: queue req %p, len %u\n",
                        ep->ep.name, req, _req->length);
              
        if (!_req || !_req->complete
                        || !_req->buf || !list_empty(&req->queue)) {
          
                DBG("invalid request\n");
                if(!_req) debug("NO REQUEST\n");
                if(!_req->complete) debug("NO REQUEST COMPLETE\n");
                if(!_req->buf) debug("NO REQUEST BUF\n");
                if(!list_empty(&req->queue)) debug("NO LIST EMPTY\n");
                return -EINVAL;
        }

It just keeps failing with "NO REQUEST BUF". I feel like I'm staring at a typo 
for days and just don't see it.

regards,
Marcel

  reply	other threads:[~2011-01-18 23:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18  0:15 [U-Boot] {Spam?} NetRxPackets Marcel
2011-01-18 21:08 ` [U-Boot] NetRxPackets Marcel
2011-01-18 21:28   ` Wolfgang Denk
2011-01-18 22:37     ` Marcel
2011-01-18 22:53       ` Wolfgang Denk
2011-01-18 23:41         ` Marcel
2011-01-18 22:54       ` Reinhard Meyer
2011-01-18 23:27         ` Marcel [this message]
2011-01-19  8:14           ` Vitaly Kuzmichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101190027.28425.korgull@home.nl \
    --to=korgull@home.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox