public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3 RESEND] MX51EVK: Use SWx macros in PMIC init
Date: Wed, 19 Jan 2011 15:25:40 +0100	[thread overview]
Message-ID: <201101191525.41038.marek.vasut@gmail.com> (raw)
In-Reply-To: <4D36C7D5.3000500@mvista.com>

On Wednesday 19 January 2011 12:15:33 Sergei Shtylyov wrote:
> On 19-01-2011 2:19, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut<marek.vasut@gmail.com>
> 
> [...]
> 
> > diff --git a/board/freescale/mx51evk/mx51evk.c
> > b/board/freescale/mx51evk/mx51evk.c index 2160d5a..bcf1934 100644
> > --- a/board/freescale/mx51evk/mx51evk.c
> > +++ b/board/freescale/mx51evk/mx51evk.c
> > @@ -198,17 +198,18 @@ static void power_init(void)
> > 
> >   	/* Set core voltage to 1.1V */
> >   	val = pmic_reg_read(REG_SW_0);
> > 
> > -	val = (val&  (~0x1F)) | 0x14;
> > +	val = (val&  (~SWx_VOLT_MASK)) | SWx_1_100V;
> > 
> >   	pmic_reg_write(REG_SW_0, val);
> >   	
> >   	/* Setup VCC (SW2) to 1.25 */
> >   	val = pmic_reg_read(REG_SW_1);
> > 
> > -	val = (val&  (~0x1F)) | 0x1A;
> > +	val = (val&  (~SWx_VOLT_MASK)) | SWx_1_250V;
> > +
> 
>     Stray newline?

Nice catch, thanks
> 
> WBR, Sergei

  reply	other threads:[~2011-01-19 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18 23:19 [U-Boot] [PATCH 1/3 v2] MC13892: Add SWx buck switchers definitions Marek Vasut
2011-01-18 23:19 ` [U-Boot] [PATCH 2/3 RESEND] MX51EVK: Use SWx macros in PMIC init Marek Vasut
2011-01-19 11:15   ` Sergei Shtylyov
2011-01-19 14:25     ` Marek Vasut [this message]
2011-01-18 23:19 ` [U-Boot] [PATCH 3/3 v4] iMX5: EfikaMX: Preliminary board support Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101191525.41038.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox