public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] armv7: add support for S5PC210 SoC
Date: Thu, 20 Jan 2011 14:31:10 +0100	[thread overview]
Message-ID: <20110120133110.51705D301D7@gemini.denx.de> (raw)
In-Reply-To: <4D382F3E.6080000@samsung.com>

Dear Minkyu Kang,

In message <4D382F3E.6080000@samsung.com> you wrote:
> S5PC210 is a 32-bit RISC and Cortex-A9 Dual Core based micro-processor.
...
> new file mode 100644
> index 0000000..69011fc
> --- /dev/null
> +++ b/arch/arm/include/asm/arch-s5pc2xx/uart.h
...
> +static int use_divslot = 0;

This is certainly wrong in a header file.

Also, please do not initialise statics to 0 or NULL.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The evolution of the human race will not be accomplished in  the  ten
thousand  years  of  tame  animals,  but in the million years of wild
animals, because man is and will always be a wild animal.
                                              - Charles Galton Darwin

  reply	other threads:[~2011-01-20 13:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10 11:58 [U-Boot] [PATCH 1/2] armv7: add support for S5PC210 SoC Minkyu Kang
2011-01-13 10:10 ` Minkyu Kang
2011-01-13 10:14   ` [U-Boot] [PATCH v2 " Minkyu Kang
2011-01-20 12:46     ` Minkyu Kang
2011-01-20 12:49       ` [U-Boot] [PATCH v3 " Minkyu Kang
2011-01-20 13:31         ` Wolfgang Denk [this message]
2011-01-21  6:34           ` Minkyu Kang
2011-01-24  7:33             ` [U-Boot] [PATCH v4 2/3] " Minkyu Kang
2011-01-27 12:25               ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110120133110.51705D301D7@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox