From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Thu, 20 Jan 2011 16:43:10 +0100
Subject: [U-Boot] [PATCH v2 2/2] armv7: add support for s5pc210
	universal board
In-Reply-To: <4D3841B2.8050102@gmail.com>
References: <4D2AF498.9000707@samsung.com>
	<AANLkTinmJu5FVSC2PR3Y=BMFPNYQXxW_XvRm-TaYHu-9@mail.gmail.com>
	<4D2ED0E1.7090001@samsung.com> <4D3841B2.8050102@gmail.com>
Message-ID: <20110120154310.726DFD301D7@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear seedshope,

In message <4D3841B2.8050102@gmail.com> you wrote:
...
> > +int dram_init(void)
> > +{
> > +	gd->ram_size = PHYS_SDRAM_1_SIZE + PHYS_SDRAM_2_SIZE;
> It is shoule to use get_ram_size() function

This, like the others, are valid comments - but:

Can you please explain why you have to quote all the 1000+
unrelated lines of the patch?

It is even difficult to spot your 4 lines of comments in 1000+ lines
of quoted patch.  Plase don't do that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He had quite a powerful intellect, but it  was  as  powerful  like  a
locomotive,  and  ran on rails and was therefore almost impossible to
steer.                          - Terry Pratchett, _Lords and Ladies_