From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 24 Jan 2011 23:09:25 +0100 Subject: [U-Boot] [PATCH 3/8 v2] Introduce the Tertiary Program loader In-Reply-To: <1295906076.2051.127.camel@haiying-laptop> References: <1291217737-3870-1-git-send-email-Haiying.Wang@freescale.com> <1291217737-3870-4-git-send-email-Haiying.Wang@freescale.com> <20110122220438.DB85EB187@gemini.denx.de> <1295842861.2196.38.camel@haiying-laptop> <20110124124919.E02EFB187@gemini.denx.de> <1295906076.2051.127.camel@haiying-laptop> Message-ID: <20110124220925.CD3B6CD1385@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Haiying Wang, In message <1295906076.2051.127.camel@haiying-laptop> you wrote: > > > What I do not understand is what the TPL_BOOT variable in the > > Makefile is good for. I cannot understand the current use. > > Well, it was used to generate the tpl image under tpl/ directory. Maybe TPL_BOOT is a bad name here, I just thought it was too simple to use TPL. It's not the name. But you use it ina few places here, buth then hard encode "tpl" in a number of other paces there. Which means that you cannot change TPL_BOOT to any other value, or building would break. So why do we need this variable? > > > > > +$(TPL_BOOT): $(TIMESTAMP_FILE) $(VERSION_FILE) depend > > > > > + $(MAKE) -C tpl/board/$(BOARDDIR) all > > > > > > > > Assume CONFIG_TPL_U_BOOT is not defined, then TPL_BOOT is not defined, > > > > and this rule will probably cause a build error, doesn't it? > > > No, I don't think there is a build error. > > > > WEell, if CONFIG_TPL_U_BOOT is not 'y', then TPL_BOOT is not > > defined, which results in this make rule: > > > > : $(TIMESTAMP_FILE) $(VERSION_FILE) depend > > $(MAKE) -C tpl/board/$(BOARDDIR) all > > > > i. e. there would be no target name befoe the semicolon. > If TPL_BOOT here is not defined, the reset(after semicolon) will not be executed, just like NAND_SPL and ONENAND_IPL etc. Sorry, I cannot follow - which reset? which semicolon? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Quantum Mechanics is God's version of "Trust me."