public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc: Fix FPU post related link warnings
Date: Tue, 25 Jan 2011 21:16:23 +0100	[thread overview]
Message-ID: <20110125201623.EA935B187@gemini.denx.de> (raw)
In-Reply-To: <1295946008-11905-1-git-send-email-galak@kernel.crashing.org>

Dear Kumar Gala,

In message <1295946008-11905-1-git-send-email-galak@kernel.crashing.org> you wrote:
> If we built POST on PPC's that didn't enable CONFIG_SYS_POST_FPU we'd
> get the following warning with newer toolchains:
> 
> powerpc-linux-gnu-ld: Warning: lib_powerpc/fpu/libpostpowerpcfpu.o
> 		      uses hard float, libpost.o uses soft float
> 
> We actually worked around this sometime ago with the following commit:
> 
> commit ce82ff05388b5ddafdf6082ef0776cce72c40b1c
> Author: Yuri Tikhonov <yur@emcraft.com>
> Date:   Sat Dec 20 14:54:21 2008 +0300
> 
>    FPU POST: fix warnings when building with 2.18 binutils
> 
> However, this only took into effect if CONFIG_SYS_POST_FPU was enabled.
> We can simply move the GNU_FPOST_ATTR out of the CONFIG_SYS_POST_FPU
> ifdef block to address the issue.
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> 
> Wolfgang, I request we think about include this patch in v2011.03 tree so we
> can all stop getting these build warnings :)
> 
> - k
> 
>  post/lib_powerpc/fpu/20001122-1.c             |    4 ++--
>  post/lib_powerpc/fpu/20010114-2.c             |    4 ++--
>  post/lib_powerpc/fpu/20010226-1.c             |    4 ++--
>  post/lib_powerpc/fpu/980619-1.c               |    4 ++--
>  post/lib_powerpc/fpu/acc1.c                   |    4 ++--
>  post/lib_powerpc/fpu/compare-fp-1.c           |    4 ++--
>  post/lib_powerpc/fpu/fpu.c                    |    4 ++--
>  post/lib_powerpc/fpu/mul-subnormal-single-1.c |    4 ++--
>  8 files changed, 16 insertions(+), 16 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No more blah, blah, blah!
	-- Kirk, "Miri", stardate 2713.6

      reply	other threads:[~2011-01-25 20:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25  9:00 [U-Boot] [PATCH] powerpc: Fix FPU post related link warnings Kumar Gala
2011-01-25 20:16 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110125201623.EA935B187@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox