From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] BLOCK: Fixup iMX51 ATA driver
Date: Tue, 1 Feb 2011 18:01:59 +0100 [thread overview]
Message-ID: <201102011801.59609.marek.vasut@gmail.com> (raw)
In-Reply-To: <4D47B237.1030901@denx.de>
On Tuesday 01 February 2011 08:11:51 Stefano Babic wrote:
> On 11/29/2010 03:18 PM, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>
> Hi Marek,
>
> in my regression tests to check if all IMX boards are compiled clean I
> found the following warnings (efikamx):
>
> mxc_ata.c:90: warning: 'pio_t0' defined but not used
> mxc_ata.c:93: warning: 'pio_t2_16' defined but not used
> mxc_ata.c:94: warning: 'pio_t2i' defined but not used
>
> As I have already merged your patch into u-boot-imx (and Albert has
> already merged it in u-boot-arm), I will post a patch on top of it to
> remove them. Anyway, have you expected that these three variables are
> not used at all ? Could I remove them ?
Yes, you can remove them. They are unused in the original freescale driver too,
stupid sed-mistake.
Thanks for the good catch :)
>
> Regards,
> Stefano
prev parent reply other threads:[~2011-02-01 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 14:18 [U-Boot] [PATCH] BLOCK: Fixup iMX51 ATA driver Marek Vasut
2011-02-01 7:11 ` Stefano Babic
2011-02-01 17:01 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102011801.59609.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox