public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Loïc Minier" <lool@dooz.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] mach-type #define mismatch for lange51/efikamx
Date: Thu, 3 Feb 2011 01:04:36 +0100	[thread overview]
Message-ID: <20110203000436.GA28542@bee.dooz.org> (raw)

        Hey!

> iMX5: EfikaMX: Preliminary board support

 u-boot-imx has:
    #define MACH_TYPE_MX51_LANGE51         2336
    #define MACH_TYPE_MX51_LANGE52         2337

 u-boot-arm has:
    #define MACH_TYPE_MX51_EFIKAMX         2336
    #define MACH_TYPE_MX51_LANGE52         2337

 and linux has:
    mx51_efikamx            MACH_MX51_EFIKAMX       MX51_EFIKAMX 2336
    mx51_lange52            MACH_MX51_LANGE52       MX51_LANGE52 2337

 but board/efikamx/efikamx.c uses MACH_TYPE_MX51_LANGE51 (and hence
 fails to build in u-boot-arm.git and u-boot.git).

 So while (Pegatron?) Lange 5.1 and 5.2 might have been more consistent,
 I think we need to switch board/efikamx/efikamx.c to the linux name
 MACH_MX51_EFIKAMX.

   Thanks!
-- 
Lo?c Minier

             reply	other threads:[~2011-02-03  0:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03  0:04 Loïc Minier [this message]
2011-02-03  6:32 ` [U-Boot] mach-type #define mismatch for lange51/efikamx Stefano Babic
2011-02-03  7:50   ` Marek Vasut
2011-02-03 11:43 ` [U-Boot] [PATCH] EfikaMX: switch to MACH_TYPE_MX51_EFIKAMX Loïc Minier
2011-02-03 14:19   ` [U-Boot] [PATCH V2] " Loïc Minier
2011-02-04 15:30     ` Stefano Babic
2011-02-05  9:48       ` Albert ARIBAUD
2011-02-05 11:25         ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110203000436.GA28542@bee.dooz.org \
    --to=lool@dooz.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox