public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] at91sam9263_nandflash build issues
Date: Thu, 3 Feb 2011 00:57:41 +0100	[thread overview]
Message-ID: <201102030057.42024.marek.vasut@gmail.com> (raw)
In-Reply-To: <20110202134300.515c3270@udp111988uds>

On Wednesday 02 February 2011 20:43:00 Scott Wood wrote:
> On Wed, 2 Feb 2011 08:49:36 +0100
> 
> Marek Vasut <marek.vasut@gmail.com> wrote:
> > diff --git a/config.mk b/config.mk
> > index 5147c35..fe1d40c 100644
> > --- a/config.mk
> > +++ b/config.mk
> > @@ -261,7 +261,7 @@ $(obj)%.s:  %.c
> > 
> >  # If the list of objects to link is empty, just create an empty
> >  built-in.o cmd_link_o_target = $(if $(strip $1),\
> > 
> > -                     $(LD) $(LDFLAGS) -r -o $@ $1,\
> > +                     $(LD) -r -o $@ $1,\
> > 
> >                       rm -f $@; $(AR) rcs $@ )
> 
> LDFLAGS was used here deliberately by commit:
> 8aba9dceebb14144e07d19593111ee3a999c37fc

Oh my, it's not my platform. Also, you missed the comment where I said the patch 
is a mess, not a patch to be merged :) This time I really only forwarded a 
bugreport from irc channel with a bad sketch of a patch.
> 
> I suspect your problem is because you have --gc-sections in
> PLATFORM_LDFLAGS.  The above commit changed architectures that set
> --gc-sections to use LDFLAGS_u-boot instead, but it missed boards that
> set it.
> 
> Also note this patch, which if applied would mean that you'd need to
> put --gc-sections in LDFLAGS_FINAL instead of LDFLAGS_u-boot:
> 
> http://patchwork.ozlabs.org/patch/81206/
> 
> -Scott

      reply	other threads:[~2011-02-02 23:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-02  7:49 [U-Boot] at91sam9263_nandflash build issues Marek Vasut
2011-02-02  8:16 ` Reinhard Meyer
2011-02-02  8:18   ` [U-Boot] AT91: dataflash: was " Reinhard Meyer
2011-02-02  9:06   ` [U-Boot] " Marek Vasut
2011-02-02 11:14 ` Wolfgang Denk
2011-02-02 19:43 ` Scott Wood
2011-02-02 23:57   ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102030057.42024.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox