From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] mach-type #define mismatch for lange51/efikamx
Date: Thu, 3 Feb 2011 08:50:06 +0100 [thread overview]
Message-ID: <201102030850.06312.marek.vasut@gmail.com> (raw)
In-Reply-To: <4D4A4BE2.1090209@denx.de>
On Thursday 03 February 2011 07:32:02 Stefano Babic wrote:
> On 02/03/2011 01:04 AM, Lo?c Minier wrote:
> > Hey!
> >>
> >> iMX5: EfikaMX: Preliminary board support
> >>
> > u-boot-imx has:
> > #define MACH_TYPE_MX51_LANGE51 2336
> > #define MACH_TYPE_MX51_LANGE52 2337
> >
> > u-boot-arm has:
> > #define MACH_TYPE_MX51_EFIKAMX 2336
> > #define MACH_TYPE_MX51_LANGE52 2337
> >
> > and linux has:
> > mx51_efikamx MACH_MX51_EFIKAMX MX51_EFIKAMX 2336
> > mx51_lange52 MACH_MX51_LANGE52 MX51_LANGE52 2337
> >
> > but board/efikamx/efikamx.c uses MACH_TYPE_MX51_LANGE51 (and hence
> > fails to build in u-boot-arm.git and u-boot.git).
> >
> > So while (Pegatron?) Lange 5.1 and 5.2 might have been more consistent,
> > I think we need to switch board/efikamx/efikamx.c to the linux name
> > MACH_MX51_EFIKAMX.
>
> Marek, what do you think about ? It seems that the machine type for
> efikamx is wrong.
It used to be lange51, that's the official code-name too. They (genesi I guess)
seem to have requested an update in linux-arm machine ID database. Obviously,
needs a change. Thanks
>
> Best regards,
> Stefano Babic
next prev parent reply other threads:[~2011-02-03 7:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 0:04 [U-Boot] mach-type #define mismatch for lange51/efikamx Loïc Minier
2011-02-03 6:32 ` Stefano Babic
2011-02-03 7:50 ` Marek Vasut [this message]
2011-02-03 11:43 ` [U-Boot] [PATCH] EfikaMX: switch to MACH_TYPE_MX51_EFIKAMX Loïc Minier
2011-02-03 14:19 ` [U-Boot] [PATCH V2] " Loïc Minier
2011-02-04 15:30 ` Stefano Babic
2011-02-05 9:48 ` Albert ARIBAUD
2011-02-05 11:25 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102030850.06312.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox