public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marcel <korgull@home.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] {Spam?} u-boot-usb DFU working but need some ideas
Date: Fri, 11 Feb 2011 19:30:19 +0100	[thread overview]
Message-ID: <201102111930.20007.korgull@home.nl> (raw)
In-Reply-To: <20110210192639.382DD14B9A38@gemini.denx.de>

Hi Wolfgang,

> In message <201102102015.59437.korgull@home.nl> you wrote:
> > The GPBR is optional in my code. I just use it because it's the nicest
> 
> > solution for me over the following options :
> I haven't seen your code yet, so I may misunderstand what you are
> actually referring to, but from what it sounds I think that should
> not be optional, but strictly separate from the DFU code.

It is separate or I will make sure it is when I post it.
 
> > Do you mean separate patches to add for example the sam9g45 USB
> > controller and another patch to add DFU and another one to add my board
> > ?
> 
> Yes.

OK.

> > It does make sense to that, I just wonder how to generate those
> > patches...... I know which files I want to include in separate patches,
> > but how do I do that ?
> 
> Normally you do this when developing the code.

Than I just check out a new u-boot-usb and port my code in there in order of 
the patches. It sounds not very difficult and at least makes sure I have several 
patches created the way it should.

> If you already have alltogehter as a huge pile of a mess, then you
> will have to go thtrough splitting this up.  Either completely
> manually (ouch...) or by using git's interactive capabilities - for
> example, "git add --interactive" can be used to select even single
> lines from hunks of changes into the next commit.
> 
> Yes, this is a painful work, but it needs to be done to make your code
> acceptable for mainline.

Understood.
I will go for the manual way as I didn't do much changes to the existing u-
boot code anyway. It's a fairly clean implementation so I should be finished 
with in a couple of hours I think.

I'll post the items this weekend. 

Thanks for all the help so far,
Marcel

      reply	other threads:[~2011-02-11 18:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-05 21:20 [U-Boot] {Spam?} u-boot-usb DFU working but need some ideas Marcel
2011-02-08 10:40 ` Detlev Zundel
2011-02-10  7:46   ` Marcel
2011-02-10  8:04     ` Wolfgang Denk
2011-02-10 19:15       ` Marcel
2011-02-10 19:26         ` Wolfgang Denk
2011-02-11 18:30           ` Marcel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102111930.20007.korgull@home.nl \
    --to=korgull@home.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox