From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] mkimage: add "-V" option to print version information
Date: Sat, 12 Feb 2011 10:37:16 +0100 [thread overview]
Message-ID: <20110212093716.77A471519FD@gemini.denx.de> (raw)
In-Reply-To: <20110211171117.b9b05b01.kim.phillips@freescale.com>
Dear Kim Phillips,
In message <20110211171117.b9b05b01.kim.phillips@freescale.com> you wrote:
> On Fri, 11 Feb 2011 23:41:43 +0100
> Wolfgang Denk <wd@denx.de> wrote:
>
> > + case 'V':
> > + /*
> > + * Skip the "U-Boot " part in
> > + * U_BOOT_VERSION by adding 7
> > + */
> > + printf("mkimage version %s\n",
> > + U_BOOT_VERSION + 7);
>
> I'd have done it without magic nor comments as
>
> U_BOOT_VERSION[sizeof("U-Boot ") + 1]
>
> or even
>
> U_BOOT_VERSION[strlen("U-Boot ")]
Hm... I would have cleaned up such locations in U-Boot as part of my
v4 patch that introduces PLAIN_VERSION - if I had found any such
code. Am I missing something?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I haven't lost my mind - it's backed up on tape somewhere."
next prev parent reply other threads:[~2011-02-12 9:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 8:56 [U-Boot] [PATCH] mkimage: add "-V" option to print version information Wolfgang Denk
2011-02-11 12:22 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2011-02-11 21:55 ` Albert ARIBAUD
2011-02-11 22:35 ` Wolfgang Denk
2011-02-11 21:52 ` [U-Boot] [PATCH] " Albert ARIBAUD
2011-02-11 22:41 ` [U-Boot] [PATCH v3] " Wolfgang Denk
2011-02-11 23:11 ` Kim Phillips
2011-02-12 6:47 ` Albert ARIBAUD
2011-02-12 9:29 ` Wolfgang Denk
2011-02-12 22:04 ` Kim Phillips
2011-02-12 9:37 ` Wolfgang Denk [this message]
2011-02-12 22:17 ` Kim Phillips
2011-02-12 23:31 ` Wolfgang Denk
2011-02-12 9:37 ` [U-Boot] [PATCH v4] " Wolfgang Denk
2011-02-12 23:13 ` Kim Phillips
2011-02-12 23:35 ` Wolfgang Denk
2011-02-13 0:08 ` Kim Phillips
2011-04-12 20:37 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212093716.77A471519FD@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox