[U-Boot] [PATCH v2 4/4] updates for DFU and atmel usba udc

Remy Bohmer
2011-02-15T18:43:34Z

Hi,

2011/2/13 Marcel Janssen <korgull@home.nl>:
> From: Marcel <korgull@home.nl>
>
> Signed-off-by: Marcel <korgull@home.nl>
> ---
> ?arch/arm/cpu/arm926ejs/at91/led.c ? | ?119 +++++++++++++++++++++++++++++++++-

Why is this part if this patch?
It does not seem to be related to USB stuff. Please make it a seperate patch.

> ?common/Makefile ? ? ? ? ? ? ? ? ? ? | ? ?1 +
> ?common/update_dfu.c ? ? ? ? ? ? ? ? | ? ?2 -
> ?drivers/usb/gadget/atmel_usba_udc.c | ? ?8 +-
> ?drivers/usb/gadget/usbdfu.c ? ? ? ? | ? 14 +++--
> ?5 files changed, 128 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/at91/led.c b/arch/arm/cpu/arm926ejs/at91/led.c
> index 0a315c4..0638a2e 100644
> --- a/arch/arm/cpu/arm926ejs/at91/led.c
> +++ b/arch/arm/cpu/arm926ejs/at91/led.c
> @@ -28,38 +28,149 @@
> ?#include <asm/arch/gpio.h>
> ?#include <asm/arch/io.h>
>
> +static unsigned int saved_state[4] = {STATUS_LED_OFF, STATUS_LED_OFF,
> + ? ? ? ? ? ? ? STATUS_LED_OFF, STATUS_LED_OFF};
> +
> +void coloured_LED_init(void)
> +{
> + ? ? ? /* Enable clock */
> + ? ? ? at91_sys_write(AT91_PMC_PCER, 1 << AT91SAM9G45_ID_PIODE);

at91_sys_write is deprecated, please use register access by struct

Why is modification of the generic at91 led code required? It is not clear.

Please, only make a patch series with only USB-DFU stuff in it, drop
the add-board code from this series. The board code is not acceptable
for mainstream since it does not follow the new
u-boot-atmel->rework110202 tree style of adding at91 boards. It will
take you a huge amount of effort to make it suitable.
Further, both parts of the patch series are not related and you are
now creating a link between the Atmel tree and the USB tree, which
makes it even more difficult.

Kind regards,

Remy