From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] CONFIG_ENV_IS_EMBEDDED problems
Date: Tue, 15 Feb 2011 04:11:24 -0500 [thread overview]
Message-ID: <201102150411.25201.vapier@gentoo.org> (raw)
In-Reply-To: <4D440EFD.70000@discworld.dascon.de>
On Saturday, January 29, 2011 07:58:37 Michael Schwingen wrote:
> I am wondering how CONFIG_ENV_IS_EMBEDDED is supposed to work.
the embedded env stuff is kind of a mess. anyone will to waste/spend time on
cleaning it up would be nice.
> As far as I understand the code, it is set automatically by
> environment.h in case the environment is in a sector in NOR flash that
> overlaps with the u-boot code.
historically, i think that's what the code attempted to do.
> However, I see two problems:
> - CONFIG_ENV_IS_EMBEDDED does not end up in autoconf.mk - however, it
> is used in common/Makefile. This does not cause problems as long as
> CONFIG_ENV_IS_IN_FLASH is also set, but the switch in the Makefile is
> either useless or broken.
well, the former cant really show up if the latter isnt defined
> - include/common.h also contains #ifdef CONFIG_ENV_IS_EMBEDDED without
> including environment.h, so that the definitions inside that block are
> never reached.
common.h has historically been a dumping ground for crap. relocating that
malloc-specific code to a better header would probably be a good idea.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110215/50e4878b/attachment.pgp
prev parent reply other threads:[~2011-02-15 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-29 12:58 [U-Boot] CONFIG_ENV_IS_EMBEDDED problems Michael Schwingen
2011-02-15 9:11 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102150411.25201.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox