public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Introduce a new linker flag LDFLAGS_FINAL
Date: Thu, 17 Feb 2011 00:01:57 -0500	[thread overview]
Message-ID: <201102170001.59271.vapier@gentoo.org> (raw)
In-Reply-To: <20110215185100.6c6e20fc@schlenkerla>

On Tuesday, February 15, 2011 19:51:00 Scott Wood wrote:
> On Tue, 15 Feb 2011 04:02:44 -0500 Mike Frysinger wrote:
> > > This included anything that cpu/board code added to LDFLAGS -- some
> > > architectures added --gc-sections, x86 added --cref, etc.  Since the
> > > above flags are added to LDFLAGS, rather than replacing them, these
> > > flags got used in the final link.
> > > 
> > > Commit 8aba9dc introduces LDFLAGS_u-boot, so that LDFLAGS is no longer
> > > the source for the flags for the final link.  It generates
> > > LDFLAGS_u-boot using PLATFORM_LDFLAGS, not LDFLAGS.  It converts most
> > > of the board/cpu updates to LDFLAGS into LDFLAGS_u-boot, but it missed
> > > --cref.
> > 
> > err, i dont think this is correct.  LDFLAGS is no longer the *only*
> > source for the final link.  if you look at the actual target, you'll see
> > it using $(LDFLAGS) $(LDFLAGS_$(@F)).
> 
> Ah.  So why is PLATFORM_LDFLAGS added into both LDFLAGS and
> LDFLAGS_u-boot? :-P

i'm not saying PLATFORM_LDFLAGS makes sense.  it certainly seems like we've 
outgrown the PLATFORM_XXX flags and could be cleaned up.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110217/515698cf/attachment.pgp 

  reply	other threads:[~2011-02-17  5:01 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 18:32 [U-Boot] [PATCH] Introduce a new linker flag LDFLAGS_FINAL Haiying.Wang at freescale.com
2011-01-31 19:33 ` Wolfgang Denk
2011-01-31 19:55   ` Scott Wood
2011-02-01  7:34     ` Wolfgang Denk
2011-02-01 14:59       ` Haiying Wang
2011-02-01 16:24       ` Scott Wood
2011-02-01 19:32         ` Wolfgang Denk
2011-02-01 19:51           ` Scott Wood
2011-02-01 20:20             ` Wolfgang Denk
2011-02-01 20:40               ` Scott Wood
2011-02-04 15:52                 ` Haiying Wang
2011-02-15  9:02                 ` Mike Frysinger
2011-02-16  0:51                   ` Scott Wood
2011-02-17  5:01                     ` Mike Frysinger [this message]
2011-02-04 22:56             ` Graeme Russ
2011-01-31 20:14   ` Haiying Wang
2011-01-31 20:30     ` Wolfgang Denk
     [not found]       ` <1297878184.1977.18.camel@haiying-laptop>
2011-02-16 18:29         ` Wolfgang Denk
2011-02-16 18:40           ` Haiying Wang
2011-02-16 18:58             ` Wolfgang Denk
2011-02-17  5:37               ` Mike Frysinger
2011-02-17  8:33                 ` Wolfgang Denk
2011-02-17 19:28               ` Haiying Wang
2011-02-17 20:38                 ` Haiying Wang
2011-02-22 19:39                   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102170001.59271.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox