From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again.
Date: Mon, 21 Feb 2011 11:58:44 +0100 [thread overview]
Message-ID: <20110221105844.ABC4915365A@gemini.denx.de> (raw)
In-Reply-To: <0F3EF05CA2A70E43B140EF090B9F97183EFE01B8@CERNXCHG22.cern.ch>
Dear Uli Raich,
In message <0F3EF05CA2A70E43B140EF090B9F97183EFE01B8@CERNXCHG22.cern.ch> you wrote:
> This version has been tested on an
> armputer-vmax board, which is similar to the at91sam9263ek
> but not on the at91sam9263ek board itself.
> A new configuration "armputer-vmax_config" has been added. This configuration
> has been tested on the hardware and is known to work. Further hardware tests
> for individual options are needed. The LCD screen was not tested.
>
>
> ---
SoB line missing, as I already remaked twice before.
Also, please run your patch through checkpatch and fix the errors:
total: 57 errors, 26 warnings, 961 lines checked
ERROR: "(foo*)" should be "(foo *)"
ERROR: Macros with complex values should be enclosed in parenthesis
ERROR: Missing Signed-off-by: line(s)
ERROR: code indent should use tabs where possible
ERROR: do not use C99 // comments
ERROR: space required after that ',' (ctx:VxV)
ERROR: trailing statements should be on next line
ERROR: trailing whitespace
WARNING: line over 80 characters
WARNING: please, no space before tabs
WARNING: please, no spaces at the start of a line
WARNING: space prohibited between function name and open parenthesis '('
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Overdrawn? But I still have checks left!
next prev parent reply other threads:[~2011-02-21 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 9:41 [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again Uli Raich
2011-02-21 10:56 ` Reinhard Meyer
2011-02-22 10:34 ` Uli Raich
2011-02-21 10:58 ` Wolfgang Denk [this message]
2011-02-21 11:00 ` Remy Bohmer
[not found] ` <4D624A5E.30105@emk-elektronik.de>
2011-02-21 12:53 ` [U-Boot] SoC specific driver changes through other custodian's trees? Wolfgang Denk
2011-02-21 13:35 ` Reinhard Meyer
2011-02-21 13:52 ` Wolfgang Denk
2011-02-21 13:09 ` [U-Boot] [PATCH 18/18] Make the at91sam9263ek compile again Andreas Bießmann
2011-02-21 13:17 ` Andreas Bießmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221105844.ABC4915365A@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox