public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too
Date: Mon, 21 Feb 2011 11:14:00 +0100	[thread overview]
Message-ID: <201102211114.01053.sr@denx.de> (raw)
In-Reply-To: <4D6222AB.5080207@dresearch.de>

Hi Steffen,

On Monday 21 February 2011 09:30:35 Steffen Sledz wrote:
> Am 11.02.2011 15:30, schrieb Steffen Sledz:
> > Signed-off-by: Mario Schuknecht <m.schuknecht@dresearch.de>
> > Signed-off-by: Steffen Sledz <sledz@dresearch.de>
> > ---
> > 
> >  drivers/mtd/cfi_flash.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
> > index dd394a8..527a3a5 100644
> > --- a/drivers/mtd/cfi_flash.c
> > +++ b/drivers/mtd/cfi_flash.c
> > @@ -1924,7 +1924,8 @@ ulong flash_get_size (phys_addr_t base, int
> > banknum)
> > 
> >  		/* Do manufacturer-specific fixups */
> >  		switch (info->manufacturer_id) {
> > 
> > -		case 0x0001:
> > +		case 0x0001: /* AMD */
> > +		case 0x0037: /* AMIC */
> > 
> >  			flash_fixup_amd(info, &qry);
> >  			break;
> >  		
> >  		case 0x001f:
> Ping!

This patch is not really a bug-fix. So I have it queued for the upcoming 
"next" branch (will open with -rc2).

But I do have a small question about the patch: Who is the author of this 
patch? You (Steffen) or Mario? If its Mario, then you should add a "From: 
Mario Schuknecht <m.schuknecht@dresearch.de>" line at the beginning of the 
mail body. If its yourself, then you should switch the Signed-off-by lines 
(author should be the first here).

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2011-02-21 10:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 14:30 [U-Boot] [PATCH] cfi_flash: use AMD fixups for AMIC (e.g. A29L160A series) too Steffen Sledz
2011-02-21  8:30 ` Steffen Sledz
2011-02-21 10:14   ` Stefan Roese [this message]
2011-02-21 12:12     ` Steffen Sledz
2011-02-21 12:13 ` [U-Boot] [PATCH v2] " Mario Schuknecht
2011-04-07  8:21   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102211114.01053.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox