From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: axi_ethernet: Add driver to u-boot
Date: Tue, 1 Mar 2011 03:48:15 -0500 [thread overview]
Message-ID: <201103010348.16352.vapier@gentoo.org> (raw)
In-Reply-To: <4D6CAF9E.4020001@monstr.eu>
On Tuesday, March 01, 2011 03:34:38 Michal Simek wrote:
> Mike Frysinger wrote:
> > On Tuesday, March 01, 2011 03:00:47 Michal Simek wrote:
> >> If both functions should return 0 then any code should check it and all
> >> others drivers should be fixed.
> >
> > i agree, but that doesnt mean new code should knowingly be left broken
>
> I agree that make no sense do not fix it right now.
err, your new driver should return the correct values. what higher levels do
or do not check does not matter, and whether other drivers do it correctly
does not matter.
> >> ep93xx_eth.c returns also 1.
> >> Anyway if is number of registered devices, "1" should means one
> >> registered device. If zero means one registered device then please
> >> point me to that documentation.
> >
> > the change hasnt been ported to all drivers yet. but new drivers should
> > be doing it as i described.
>
> How does it look like phy lib u-boot support?
i dont know what you mean ... how is phylib relevant to this ? or are you
just asking in general ?
> > also, you should change the "hang()" to "return 0" in the init func.
>
> Are you sure return 0 which should mean success. Anything different from 0
> seems to me relevant.
as i said, the initialize function is not returning "success" or "failure".
it is returning "# of devices registered". if you cannot register any, you
should return 0. having the boot process fail because of network issues
doesnt make much sense when u-boot can do quite a lot without the network.
including updating itself via other means.
> I maintain emaclite driver and none tell me this that's why the process is
> so slow. I believe if you release that documentation, which you are
> talking about, then others will clean/test their drivers.
the behavior i describe isnt a decision i made. it was made by the previous
net maintainer and agreed upon by others in the discussion.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110301/5c643037/attachment.pgp
next prev parent reply other threads:[~2011-03-01 8:48 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 9:40 [U-Boot] [PATCH] net: axi_ethernet: Add driver to u-boot Michal Simek
2011-02-28 17:36 ` Mike Frysinger
2011-02-28 18:50 ` Michal Simek
2011-02-28 19:29 ` Mike Frysinger
2011-03-01 8:00 ` Michal Simek
2011-03-01 8:18 ` Mike Frysinger
2011-03-01 8:34 ` Michal Simek
2011-03-01 8:48 ` Mike Frysinger [this message]
2011-03-01 9:29 ` Michal Simek
2011-03-03 21:51 ` Mike Frysinger
2011-03-04 10:09 ` Michal Simek
2011-03-09 7:34 ` Mike Frysinger
2011-03-09 7:38 ` Mike Frysinger
2011-03-01 8:37 ` Michal Simek
2011-03-01 8:58 ` Mike Frysinger
2011-03-01 8:19 ` Michal Simek
2011-03-01 8:28 ` Mike Frysinger
2011-03-01 8:46 ` Michal Simek
2011-03-01 9:10 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2011-08-30 12:05 [U-Boot] [PATCH v2] net: ll_temac: Add LL TEMAC " Michal Simek
2011-08-30 12:05 ` [U-Boot] [PATCH] net: axi_ethernet: Add " Michal Simek
2011-08-31 12:19 ` Marek Vasut
2011-08-31 14:46 ` Michal Simek
2011-08-31 15:19 ` Marek Vasut
2011-09-01 7:17 ` Michal Simek
2011-09-01 8:18 ` Marek Vasut
2011-09-01 8:55 ` Michal Simek
2011-09-01 10:07 ` Marek Vasut
2011-09-01 11:04 ` Michal Simek
2011-09-01 12:47 ` Wolfgang Denk
2011-08-31 20:13 ` Wolfgang Denk
2011-08-31 19:24 ` Mike Frysinger
2011-09-01 6:52 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103010348.16352.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox