[U-Boot] [PATCH] net: axi_ethernet: Add driver to u-boot

Wolfgang Denk
2011-09-01T12:47:14Z

Dear Michal Simek,

In message <4E5F4883.3080409@monstr.eu> you wrote:
>
> > Well I see it both ways ... 0x40000000 == 1 << 30 ... it's the same thing. On
> > the other note, it's hard to count the zeroes in there AND you can mistake 0 and
> > 8 in a huge series of those.
> >
> > Also, you can have whatever you want in your repo if you seriously care to
> > invest the energy into maintaining it just because you need to be stubborn. But
> > it'd really be great if you invested that energy in a more productive manner ;-)
>
> There are two points of view. And both have con & pro.
> I don't want to argue. Net custodian should decided if is OK or not.

I can parse 0x00200000 much faster than '1 << 21' so my personal
preference for such masks is the raw hex numbers.

But this is just that: a personal preference. I see no problem with
using either one or the other form, and I have no really strong
preferences. In any case this should not be a reason for serious
fights - it's a matter of taste issue, not more.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
A witty saying proves nothing, but saying something pointless gets
people's attention.