[U-Boot] [PATCH] net: axi_ethernet: Add driver to u-boot

Mike Frysinger
2011-03-01T08:18:12Z

On Tuesday, March 01, 2011 03:00:47 Michal Simek wrote:
> If both functions should return 0 then any code should check it and all
> others drivers should be fixed.

i agree, but that doesnt mean new code should knowingly be left broken

> > the init func is a special beast -- it returns the # of devices
> > registered, not "1 is success".
>
> Where is it written?

atm, only the mailing list. i have a local patch that i havent gotten around
to pushing up yet for the README.drivers.eth.

> ep93xx_eth.c returns also 1.
> Anyway if is number of registered devices, "1" should means one registered
> device. If zero means one registered device then please point me to that
> documentation.

the change hasnt been ported to all drivers yet. but new drivers should be
doing it as i described.

also, you should change the "hang()" to "return 0" in the init func.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110301/f910b693/attachment.pgp