[U-Boot] [PATCH 5/9] ARM: Rename CONFIG_SKIP_LOWLEVEL_INIT to CONFIG_SKIP_CPU_INIT_CRIT

Michael Spang
2011-04-26T03:44:17Z

On Sun, Apr 24, 2011 at 7:53 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Michael Spang,
>
> In message <1300391223-11879-6-git-send-email-mspang@csclub.uwaterloo.ca> you wrote:
>> For ARM, the CONFIG_SKIP_LOWLEVEL_INIT option implies that the
>> cpu_init_crit and lowlevel_init assembly functions are skipped. We may
>> want to skip only lowlevel_init, so rename the option that skips both
>> to CONFIG_SKIP_CPU_INIT_CRIT. The MIPS option of the same name
>> is not renamed.
>
> This is an inconsistency between architectures which I dislike.
>
> Also, what in case we should want to skip only cpu_init_crit and not
> lowlevel_init? If we need to handle these separately, then we need 2
> CONFIG options.

The CPU initialization is idempotent, so I can't think of a reason why
it would be required to skip it. So, we might be able to change
CONFIG_SKIP_CPU_INIT_CRIT to CONFIG_SKIP_LOWLEVEL_INIT in most cases.
I'm just hesitant to do so because I don't have a variety of boards to
test on.

Michael