[U-Boot] [PATCH 1/9] arm926ej-s: Invalidate instruction cache in flush_cache

Albert ARIBAUD
2013-07-29T14:09:21Z

Hi Michael,

On Mon, 29 Jul 2013 08:57:53 -0400, Michael Spang
<mspang@csclub.uwaterloo.ca> wrote:

> Albert,
>
> That's not a correct characterization of the bug.
>
> The incoherent cache lines are from before the relocation stage. If
> U-Boot is relocating from RAM, and later copies the OS there without
> invalidating those lines, then that's a bug in U-Boot.

Thanks for this pointing out this scenario, which is correct, although
it was not raised in the original bug description.

I begs however the question whether anything from re-relocation can
survive in the icache from between the moment the relocation starts and
the moment the OS is given transfer to. IOW, was this issue actually
met?

Anyway I stand by my statement that even if there is an issue to fix,
this patch fixes it in the wrong place.

> Michael

Amicalement,
--
Albert.