public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC v2] Fix build problems caused by "_end" -> "__bss_end__" rename
Date: Tue, 29 Mar 2011 21:51:42 +0200	[thread overview]
Message-ID: <20110329195142.EF425EDFFCF@gemini.denx.de> (raw)
In-Reply-To: <1301402371-8697-1-git-send-email-wd@denx.de>

Dear Po-Yu Chuang,

In message <1301402371-8697-1-git-send-email-wd@denx.de> I wrote:
> Commit 44c6e65 "rename _end to __bss_end__ broke building of a large
> number of systems (at least all PowerPC?):
> 
> libstubs.o: In function `app_startup':
> examples/standalone/stubs.c:197: undefined reference to `__bss_end__'
> 
> The rename should not be done for the files in the
> examples/standalone/ directory, as these are not using the code from
> start.S, but do their own BSS clearing, and either use their own
> linker scripts or the ones provided by the compilers.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> ---
> V2:	Instead of messing with linker defines, revert the patch in
> 	question for the files in examples/standalone/ as suggested by
> 	Albert Aribaud. (Thanks!)

Only now I realize that you submitted the very same patch before.
Stupid me.

Does that mean that we have an agreement that this hould be the fix
then?  If yes, I would like to pull this in (Po-Yu Chuang's patch,
that is).

Do you agree?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A weak mind is like a microscope, which magnifies trifling things,
but cannot receive great ones.      -- Philip Earl of Chesterfield

  reply	other threads:[~2011-03-29 19:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28  6:20 [U-Boot] current head don;t compile for mpc52xx based boards Heiko Schocher
2011-03-28  6:33 ` Wolfgang Denk
2011-03-28  7:29   ` Po-Yu Chuang
2011-03-28  8:40     ` [U-Boot] [PATCH RFC] Fix build problems caused by "_end" -> "__bss_end__" rename Wolfgang Denk
2011-03-28  8:48       ` Po-Yu Chuang
2011-03-28  8:54         ` Wolfgang Denk
2011-03-28  9:07           ` Po-Yu Chuang
2011-03-28 10:25             ` Wolfgang Denk
2011-03-28 16:42       ` Albert ARIBAUD
2011-03-29 12:39         ` Wolfgang Denk
2011-03-29 12:39         ` [U-Boot] [PATCH RFC v2] " Wolfgang Denk
2011-03-29 19:51           ` Wolfgang Denk [this message]
2011-03-30  1:38             ` Po-Yu Chuang
2011-03-31  5:37               ` Kumar Gala
2011-03-28  8:43     ` [U-Boot] [RFC PATCH] rename __bss_end__ back to _end for standalone programs Po-Yu Chuang
2011-03-31  6:55       ` Wolfgang Denk
2011-03-28  8:52     ` [U-Boot] current head don;t compile for mpc52xx based boards Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110329195142.EF425EDFFCF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox