From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 31 Mar 2011 17:58:51 +0200 Subject: [U-Boot] [PATCH] serial: ns16550: fix different reg size access In-Reply-To: <1301586774-25447-1-git-send-email-leiwen@marvell.com> References: <1301586774-25447-1-git-send-email-leiwen@marvell.com> Message-ID: <20110331155851.BA1F1F03209@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Lei Wen, In message <1301586774-25447-1-git-send-email-leiwen@marvell.com> you wrote: > Some hardware would dysfunctional if only access the register by > byte. This patch is tend to recover original access the responding > register according to CONFIG_SYS_NS16550_REG_SIZE. Can you please explain on what board, and with which tool chain, you see any problems? > +- CONFIG_SYS_NS16550_MAX_REG_SIZE: > + Define the ns16550 max register size, > + if the CONFIG_SYS_NS16550_REG_SIZE is smaller than this value, > + use padding to fill those gap. This makes no sense to me. A register is always one specific size, so the term "MAX_REG_SIZE" is bogus. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Landru! Guide us! -- A Beta 3-oid, "The Return of the Archons", stardate 3157.4