From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 03/23] keymile: Fix Coding style issues for keymile boards.
Date: Fri, 1 Apr 2011 18:17:51 -0500 [thread overview]
Message-ID: <20110401181751.d2c2f4bf.kim.phillips@freescale.com> (raw)
In-Reply-To: <20110401225148.6A12E142E060@gemini.denx.de>
On Sat, 2 Apr 2011 00:51:48 +0200
Wolfgang Denk <wd@denx.de> wrote:
> Dear Kim Phillips,
>
> In message <20110401173209.55577aea.kim.phillips@freescale.com> you wrote:
> > On Fri, 1 Apr 2011 09:16:15 +0200
> > Heiko Schocher <hs@denx.de> wrote:
> >
> > > - use I/O accessors
> > > -> For accessing the FPGA therefore a struct km_bec_fpga
> > > is introduced.
> > > - no longer externs needed
> > > - to defines, that only select functions, don;t assign a
> > > numeric value
> > > - Codingstyle changes to prevent checkpatch errors/warnings
> > >
> > > Signed-off-by: Heiko Schocher <hs@denx.de>
> > > cc: Kim Phillips <kim.phillips@freescale.com>
> > > cc: Holger Brunck <holger.brunck@keymile.com>
> > > cc: Wolfgang Denk <wd@denx.de>
> > > cc: Detlev Zundel <dzu@denx.de>
> > > cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> > > cc: Prafulla Wadaskar <prafulla@marvell.com>
> > > ---
> >
> > Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
>
> Why do you send a "Signed-off-by" here?
>
> Did you mean "Acked-by:" ?
>
> Signed-off-by "certifies that you wrote it or otherwise have the right
> to pass it on as a open-source patch." However, you have not been
> anywhere in the queue of creating or forwarding these patches?
as 83xx maintainer, I sign off on all patches committed to the mpc83xx
tree, which are subsequently 'forwarded' to the main u-boot tree. This
particular case is no different, except the 83xx patches here are too
intertwined with other, non-83xx ones. So to facilitate the process, I
sign them off on-list such that they can be applied as-is to the
main u-boot tree.
hth,
Kim
next prev parent reply other threads:[~2011-04-01 23:17 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 13:29 [U-Boot] [PATCH 0/20] keymile board update Heiko Schocher
2011-03-08 13:29 ` [U-Boot] [PATCH 01/20] keymile: rework headerfiles for keymile boards Heiko Schocher
2011-03-13 22:00 ` Wolfgang Denk
2011-03-14 7:16 ` Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 02/20] mpc832x: add support for the mpc8321 based suvd3 board Heiko Schocher
2011-03-13 22:11 ` Wolfgang Denk
2011-03-14 7:20 ` Heiko Schocher
2011-03-14 12:38 ` Wolfgang Denk
2011-03-08 13:30 ` [U-Boot] [PATCH 03/20] mpc832x: add support for mpc8321 based tuxa1 board Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 04/20] mpc832x: add support for mpc8321 based tuda1 board Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 05/20] arm: add support for kirkwood based mgcoge2un board Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 06/20] arm: add support of Kirkwood based board SUEN8 Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 07/20] ppc: add support for ppc based board mgcoge2ne Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 08/20] keymile, 8321 boards: move common definitions to km8321-common.h Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 09/20] powerpc, 83xx: add kmsupx5 board support Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 10/20] km-arm: i2c support for suenx based boards Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 11/20] km_arm: change some register values for SDRAM initialization Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 12/20] ppc, 8321: cleanup tuxa1, tuda1 and suvd3 support Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 13/20] keymile, common; fix i2c deblocking support Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 14/20] arm, keymile: updates for the arm based boards from keymile Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 15/20] keymile boards: add CONFIG_PIGGY_MAC_ADRESS_OFFSET Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 16/20] keymile, common: add setting of some environment variables Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 17/20] ppc, arm: rework and enhance keymile-common.h Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 18/20] keymile boards: support of boardId / hwkey lists Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 19/20] keymile-common.h: remove IO mux stuff Heiko Schocher
2011-03-08 13:30 ` [U-Boot] [PATCH 20/20] ppc, mgcoge, mgcoge2ne: add DIP switch detection Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 00/21] keymile board update Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 01/21] arm, keymile: rename MACH_SUEN3 to MACH_KM_KIRKWOOD Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 02/21] ppc, arm: adapt keymile header Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 03/21] arm, ppc: rework environment variables for keymile boards Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 04/21] mpc832x: add support for the mpc8321 based suvd3 board Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 05/21] mpc832x: add support for mpc8321 based tuxa1 board Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 06/21] mpc832x: add support for mpc8321 based tuda1 board Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 07/21] arm: add support for kirkwood based mgcoge2un board Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 08/21] arm: add support of Kirkwood based board SUEN8 Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 09/21] ppc: add support for ppc based board mgcoge2ne Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 10/21] keymile, 8321 boards: move common definitions to km8321-common.h Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 11/21] powerpc, 83xx: add kmsupx5 board support Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 12/21] km-arm: i2c support for suenx based boards Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 13/21] km_arm: change some register values for SDRAM initialization Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 14/21] ppc, 8321: cleanup tuxa1, tuda1 and suvd3 support Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 15/21] keymile, common; fix i2c deblocking support Heiko Schocher
2011-03-15 9:03 ` [U-Boot] [PATCH v2 16/21] arm, keymile: updates for the arm based boards from keymile Heiko Schocher
2011-03-15 9:04 ` [U-Boot] [PATCH v2 17/21] keymile boards: add CONFIG_PIGGY_MAC_ADRESS_OFFSET Heiko Schocher
2011-03-15 9:04 ` [U-Boot] [PATCH v2 18/21] keymile, common: add setting of some environment variables Heiko Schocher
2011-03-15 9:04 ` [U-Boot] [PATCH v2 19/21] ppc, arm: rework and enhance keymile-common.h Heiko Schocher
2011-03-15 9:04 ` [U-Boot] [PATCH v2 20/21] keymile boards: support of boardId / hwkey lists Heiko Schocher
2011-03-15 9:04 ` [U-Boot] [PATCH v2 21/21] keymile-common.h: remove IO mux stuff Heiko Schocher
2011-03-21 7:01 ` [U-Boot] [PATCH v3 00/23] keymile board update Heiko Schocher
2011-03-21 7:01 ` [U-Boot] [PATCH v3 01/23] powerpc, mpc83xx: add missing functions to mpc83xx.h Heiko Schocher
2011-03-31 0:40 ` Kim Phillips
2011-03-31 5:38 ` Heiko Schocher
2011-03-31 15:54 ` Kim Phillips
2011-03-21 7:01 ` [U-Boot] [PATCH v3 02/23] arm, keymile: rename MACH_SUEN3 to MACH_KM_KIRKWOOD Heiko Schocher
2011-03-21 7:01 ` [U-Boot] [PATCH v3 03/23] keymile: Fix Coding style issues for keymile boards Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 04/23] ppc, arm: adapt keymile header Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v5 05/23] arm, ppc: rework environment variables for keymile boards Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 06/23] mpc832x: add support for the mpc8321 based suvd3 board Heiko Schocher
2011-03-31 0:43 ` Kim Phillips
2011-03-31 6:02 ` Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 07/23] mpc832x: add support for mpc8321 based tuxa1 board Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 08/23] mpc832x: add support for mpc8321 based tuda1 board Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 09/23] arm: add support for kirkwood based mgcoge2un board Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 10/23] arm: add support of Kirkwood based board SUEN8 Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 11/23] ppc: add support for ppc based board mgcoge2ne Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 12/23] keymile, 8321 boards: move common definitions to km8321-common.h Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 13/23] powerpc, 83xx: add kmsupx5 board support Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 14/23] km-arm: i2c support for suenx based boards Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 15/23] km_arm: change some register values for SDRAM initialization Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 16/23] ppc, 8321: cleanup tuxa1, tuda1 and suvd3 support Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 17/23] keymile, common; fix i2c deblocking support Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 18/23] arm, keymile: updates for the arm based boards from keymile Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 19/23] keymile boards: add CONFIG_PIGGY_MAC_ADRESS_OFFSET Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 20/23] keymile, common: add setting of some environment variables Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 21/23] ppc, arm: rework and enhance keymile-common.h Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 22/23] keymile boards: support of boardId / hwkey lists Heiko Schocher
2011-03-21 7:02 ` [U-Boot] [PATCH v3 23/23] keymile-common.h: remove IO mux stuff Heiko Schocher
2011-03-22 5:50 ` [U-Boot] [PATCH v3 00/23] keymile board update Prafulla Wadaskar
2011-03-22 6:14 ` Heiko Schocher
2011-03-22 8:30 ` Holger Brunck
2011-03-27 16:30 ` Albert ARIBAUD
2011-04-01 7:16 ` [U-Boot] [PATCH v4 " Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 01/23] powerpc, mpc83xx: add missing functions to include/common.h Heiko Schocher
2011-04-01 22:31 ` Kim Phillips
2011-04-02 13:04 ` Albert ARIBAUD
2011-04-05 1:26 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 02/23] arm, keymile: rename MACH_SUEN3 to MACH_KM_KIRKWOOD Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 03/23] keymile: Fix Coding style issues for keymile boards Heiko Schocher
2011-04-01 22:32 ` Kim Phillips
2011-04-01 22:51 ` Wolfgang Denk
2011-04-01 23:17 ` Kim Phillips [this message]
2011-04-27 11:39 ` Wolfgang Denk
2011-04-28 0:02 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 04/23] ppc, arm: adapt keymile header Heiko Schocher
2011-04-01 22:32 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 05/23] arm, ppc: rework environment variables for keymile boards Heiko Schocher
2011-04-01 22:33 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 06/23] mpc832x: add support for the mpc8321 based suvd3 board Heiko Schocher
2011-04-01 22:33 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 07/23] mpc832x: add support for mpc8321 based tuxa1 board Heiko Schocher
2011-04-01 22:33 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 08/23] mpc832x: add support for mpc8321 based tuda1 board Heiko Schocher
2011-04-01 22:34 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 09/23] arm: add support for kirkwood based mgcoge2un board Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 10/23] arm: add support of Kirkwood based board SUEN8 Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 11/23] ppc: add support for ppc based board mgcoge2ne Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 12/23] keymile, 8321 boards: move common definitions to km8321-common.h Heiko Schocher
2011-04-01 22:34 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 13/23] powerpc, 83xx: add kmsupx5 board support Heiko Schocher
2011-04-01 22:34 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 14/23] km-arm: i2c support for suenx based boards Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 15/23] km_arm: change some register values for SDRAM initialization Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 16/23] ppc, 8321: cleanup tuxa1, tuda1 and suvd3 support Heiko Schocher
2011-04-01 22:35 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 17/23] keymile, common; fix i2c deblocking support Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 18/23] arm, keymile: updates for the arm based boards from keymile Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 19/23] keymile boards: add CONFIG_PIGGY_MAC_ADRESS_OFFSET Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 20/23] keymile, common: add setting of some environment variables Heiko Schocher
2011-04-01 22:35 ` Kim Phillips
2011-04-01 7:16 ` [U-Boot] [PATCH v4 21/23] ppc, arm: rework and enhance keymile-common.h Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 22/23] keymile boards: support of boardId / hwkey lists Heiko Schocher
2011-04-01 7:16 ` [U-Boot] [PATCH v4 23/23] keymile-common.h: remove IO mux stuff Heiko Schocher
2011-04-29 22:48 ` [U-Boot] [PATCH v4 00/23] keymile board update Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110401181751.d2c2f4bf.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox