public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v4] powerpc: clean up DIU macro definitions for Freescale reference boards
Date: Tue, 05 Apr 2011 12:58:12 +0200	[thread overview]
Message-ID: <20110405105812.C4ABC151F83@gemini.denx.de> (raw)
In-Reply-To: <1297811359-28389-1-git-send-email-timur@freescale.com>

Dear Timur Tabi,

In message <1297811359-28389-1-git-send-email-timur@freescale.com> you wrote:
> Clean up the macro defintions used to enable DIU (video) support on the
> MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS,
> which is newer.  Add software cursor support to all three boards.

Software cursor support should be split off into a separate patch.
And CONFIG_VIDEO_SW_CURSOR needs to be documented.

> Also document the CONFIG_FSL_DIU_FB in the README.
...
> +		The DIU driver will look for the 'monitor' environment variable,
> +		and if defined, enable the DIU as a console during boot.  This
> +		variable should be set to one of these values:
> +
> +			'0'	Output video to the DVI connector
> +			'1'	Output video to the LVDS connector
> +			'2'	Output video to the Dual-Link LVDS connector

Maybe it would be more user-friendly if we used easy to remember names
instead of some magic numbers, like "dvi", "lvds" resp. "dlvds" (or
whatever) ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I used to be indecisive, now I'm not sure.

  parent reply	other threads:[~2011-04-05 10:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 23:09 [U-Boot] [PATCH] [v4] powerpc: clean up DIU macro definitions for Freescale reference boards Timur Tabi
2011-02-18 20:51 ` Timur Tabi
2011-04-04 18:14   ` Kumar Gala
2011-04-04 18:57     ` Wolfgang Denk
2011-04-04 19:01       ` Timur Tabi
2011-04-04 19:08         ` Wolfgang Denk
2011-04-05  3:22       ` Kumar Gala
2011-04-05 10:54         ` Wolfgang Denk
2011-04-04 20:59 ` Anatolij Gustschin
2011-04-05  3:33 ` Kumar Gala
2011-04-05 10:58 ` Wolfgang Denk [this message]
2011-04-05 11:09   ` Tabi Timur-B04825

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110405105812.C4ABC151F83@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox